[SERVER-23742] Fix or remove version checking in MongoRunner.runMongoTool() Created: 14/Apr/16  Updated: 21/Nov/16  Resolved: 02/Jun/16

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 3.2.8, 3.3.8

Type: Bug Priority: Major - P3
Reporter: Max Hirschhorn Assignee: Gabriel Russell (Inactive)
Resolution: Done Votes: 0
Labels: code-only
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Completed:
Sprint: Server Tools 15 (6/3/16)
Participants:
Linked BF Score: 0

 Description   

MongoRunner.getBinVersionFor(opts.binVersion) === '' will never return true after the changes from SERVER-23547 and therefore never pass the --dialTimeout to the mongo tool. The --dialTimeout command line option was backported to the 3.2 and 3.0 version of the mongo tools, which may obviate the need for version checking if we aren't concerned about testing particular minor versions of the tools against the server.



 Comments   
Comment by Githook User [ 08/Jun/16 ]

Author:

{u'username': u'gabrielrussell', u'name': u'Gabriel Russell', u'email': u'gabriel.russell@mongodb.com'}

Message: SERVER-23742 use dialTimeout with supported tools versions

(cherry picked from commit e7ab7280a24eb71f6915feb30f44050a54322a81)
Branch: v3.2
https://github.com/mongodb/mongo/commit/20ea43a6147731bc2ea78363d7a33dce2942884a

Comment by Max Hirschhorn [ 03/Jun/16 ]

Agreed, we've seen these connection timeouts in the mongodb-mongo-v3.2 Evergreen project, so passing --dialTimeout should alleviate those. Requesting approval from ramon.fernandez and kamran.khan.

Comment by Gabriel Russell (Inactive) [ 03/Jun/16 ]

max.hirschhorn I should backport this to 3.2, don't you think?

Comment by Githook User [ 02/Jun/16 ]

Author:

{u'username': u'gabrielrussell', u'name': u'Gabriel Russell', u'email': u'gabriel.russell@mongodb.com'}

Message: SERVER-23742 use dialTimeout with supported tools versions
Branch: master
https://github.com/mongodb/mongo/commit/e7ab7280a24eb71f6915feb30f44050a54322a81

Generated at Thu Feb 08 04:04:21 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.