[SERVER-23762] ValidateAdaptor::validate() should return non-OK status if it fails. Created: 15/Apr/16  Updated: 17/Nov/16  Resolved: 19/Apr/16

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: 3.3.4
Fix Version/s: 3.0.12, 3.2.6, 3.3.5

Type: Bug Priority: Critical - P2
Reporter: Robert Guo (Inactive) Assignee: Robert Guo (Inactive)
Resolution: Done Votes: 0
Labels: code-only
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Completed:
Sprint: TIG 13 (04/22/16)
Participants:

 Description   

RecordStoreV1Base::validate uses the adaptor's return value to determine if data is corrupted. So the adaptor should be able to return non-OK status.
https://github.com/mongodb/mongo/blob/master/src/mongo/db/storage/mmap_v1/record_store_v1_base.cpp#L735



 Comments   
Comment by Githook User [ 21/Apr/16 ]

Author:

{u'username': u'guoyr', u'name': u'Robert Guo', u'email': u'robert.guo@10gen.com'}

Message: SERVER-23762 validate() should fail when encountering invalid BSON

(cherry picked from commit ce39e32d01e3a909948f850360040809ac7c8a8d)
(cherry picked from commit 5089357158122b3c8b2c146210ac15fe9451c21c)
Branch: v3.0
https://github.com/mongodb/mongo/commit/176011c910ac034210aa902917457d5a61c7a516

Comment by Githook User [ 21/Apr/16 ]

Author:

{u'username': u'guoyr', u'name': u'Robert Guo', u'email': u'robert.guo@10gen.com'}

Message: SERVER-23762 validate() should fail when encountering invalid BSON

(cherry picked from commit ce39e32d01e3a909948f850360040809ac7c8a8d)
Branch: v3.2
https://github.com/mongodb/mongo/commit/5089357158122b3c8b2c146210ac15fe9451c21c

Comment by Githook User [ 19/Apr/16 ]

Author:

{u'username': u'guoyr', u'name': u'Robert Guo', u'email': u'robert.guo@10gen.com'}

Message: SERVER-23762 validate() should fail when encountering invalid BSON
Branch: master
https://github.com/mongodb/mongo/commit/ce39e32d01e3a909948f850360040809ac7c8a8d

Generated at Thu Feb 08 04:04:24 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.