[SERVER-23797] Remove fsync2.js in favor of fsync.js Created: 19/Apr/16  Updated: 02/May/18  Resolved: 19/May/16

Status: Closed
Project: Core Server
Component/s: Diagnostics
Affects Version/s: 3.3.4
Fix Version/s: 3.3.8

Type: Improvement Priority: Major - P3
Reporter: James Wahlin Assignee: Kyle Suarez
Resolution: Done Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-23256 Refactor and expand system.profile me... Closed
Backwards Compatibility: Fully Compatible
Sprint: Integrate+Tuning 15 (06/03/16)
Participants:

 Description   

core/fsync.js has been (relatively) recently rewritten, and as such is superior to noPassthroughWithMongod/fsync2.js in most ways. It also gets coverage in the parallel tester. Rather than improve fsync2.js or move it to the parallel testing suite, we should simply remove it and improve fsync.js to take on any coverage lost in fsync2.js.

Original Description

Currently fsync2.js is excluded from parallel testing due to an earlier bug where fsyncLock would block reads. With the resolution of SERVER-4243, fsync2.js can now be run in parallel with most jstests.

The only tests that should not run in parallel with those that perform fsyncLock are tests that enable profiling and test system.profile content.

fsync2.js should join the profiling tests in the parallelTester list, which runs all tests in the list serially, preventing overlap.



 Comments   
Comment by Githook User [ 19/May/16 ]

Author:

{u'username': u'ksuarz', u'name': u'Kyle Suarez', u'email': u'kyle.suarez@mongodb.com'}

Message: SERVER-23797 remove fsync2.js in favor of fsync.js
Branch: master
https://github.com/mongodb/mongo/commit/ca9cb5e288aec54a62823e22e5e4125d0d1b4f3f

Generated at Thu Feb 08 04:04:30 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.