[SERVER-23831] Remove the 'fastmodinsert' metric Created: 20/Apr/16  Updated: 31/May/19  Resolved: 31/May/19

Status: Closed
Project: Core Server
Component/s: Diagnostics, Querying
Affects Version/s: None
Fix Version/s: 4.1.14

Type: Task Priority: Major - P3
Reporter: James Wahlin Assignee: Xin Hao Zhang (Inactive)
Resolution: Done Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Documented
is documented by DOCS-12769 Docs for SERVER-23831: Remove the 'fa... Closed
Related
related to SERVER-23272 Remove misleading/not useful diagnost... Closed
Backwards Compatibility: Minor Change
Sprint: Query 2019-06-03, Query 2019-06-17
Participants:

 Description   

The 'fastmodinsert' metric reported in the profiler and slow diagnostic log for CRUD operations was deprecated under SERVER-23272 / DOCS-7697 and will be removed under this ticket.

fastmodinsert tracks update operations that result in an insert, given the update is structured as a document replacement, rather than modification. While at one point of time it is possible that this was useful information (questionable given it is hard to find reference to it providing value in either public or internal posts), it is no longer used in a meaningful way. It is not clear that a distinction should be made between a replacement style update and a modifier update that result in an insert or that one is necessarily more expensive than the other.



 Comments   
Comment by Githook User [ 31/May/19 ]

Author:

{'name': 'Xin Hao Zhang', 'email': 'xinhao.zhang@10gen.com', 'username': 'xinhaoz'}

Message: SERVER-23831 Remove fastmodinsert
Branch: master
https://github.com/mongodb/mongo/commit/933c6ad19c3f19a964c74a5174cbcf11cde0a66e

Comment by James Wahlin [ 29/May/19 ]

Updated this ticket's description to reflect our reasoning for removal.

Comment by David Storch [ 29/May/19 ]

james.wahlin, can you describe what fastmodinsert used to track, and why this diagnostic information is no longer needed?

Comment by James Wahlin [ 09/Apr/19 ]

We should consider removing this. AFAIK there have been no complaints filed about deprecation of this metric.

Generated at Thu Feb 08 04:04:35 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.