[SERVER-23831] Remove the 'fastmodinsert' metric Created: 20/Apr/16 Updated: 31/May/19 Resolved: 31/May/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Diagnostics, Querying |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.14 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | James Wahlin | Assignee: | Xin Hao Zhang (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Minor Change | ||||||||||||||||
| Sprint: | Query 2019-06-03, Query 2019-06-17 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
The 'fastmodinsert' metric reported in the profiler and slow diagnostic log for CRUD operations was deprecated under fastmodinsert tracks update operations that result in an insert, given the update is structured as a document replacement, rather than modification. While at one point of time it is possible that this was useful information (questionable given it is hard to find reference to it providing value in either public or internal posts), it is no longer used in a meaningful way. It is not clear that a distinction should be made between a replacement style update and a modifier update that result in an insert or that one is necessarily more expensive than the other. |
| Comments |
| Comment by Githook User [ 31/May/19 ] |
|
Author: {'name': 'Xin Hao Zhang', 'email': 'xinhao.zhang@10gen.com', 'username': 'xinhaoz'}Message: |
| Comment by James Wahlin [ 29/May/19 ] |
|
Updated this ticket's description to reflect our reasoning for removal. |
| Comment by David Storch [ 29/May/19 ] |
|
james.wahlin, can you describe what fastmodinsert used to track, and why this diagnostic information is no longer needed? |
| Comment by James Wahlin [ 09/Apr/19 ] |
|
We should consider removing this. AFAIK there have been no complaints filed about deprecation of this metric. |