[SERVER-24038] Linter should check that cpp files include basic.h Created: 03/May/16 Updated: 30/Aug/23 Resolved: 29/Aug/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Mathias Stearn | Assignee: | [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive) |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | platforms-re-triaged | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Server Development Platform
|
||||||||
| Participants: | |||||||||
| Description |
|
Our rules require it, and failure to do that causes weird compiler errors on windows with unrelated changes. |
| Comments |
| Comment by Andy Schwerin [ 30/Aug/23 ] |
|
This is not the opposite of That said, I think that we now use force-include to ensure basic.h is in all source files at the right position, so we should probably start linting that no files explicitly include basic.h. We could either retake |
| Comment by Alex Neben [ 29/Aug/23 ] |
|
This is in the opposite of |