[SERVER-24038] Linter should check that cpp files include basic.h Created: 03/May/16  Updated: 30/Aug/23  Resolved: 29/Aug/23

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Mathias Stearn Assignee: [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive)
Resolution: Won't Fix Votes: 0
Labels: platforms-re-triaged
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-7504 Core Server Headers should not includ... Closed
Assigned Teams:
Server Development Platform
Participants:

 Description   

Our rules require it, and failure to do that causes weird compiler errors on windows with unrelated changes.



 Comments   
Comment by Andy Schwerin [ 30/Aug/23 ]

This is not the opposite of SERVER-7504. SERVER-7504 requires that header files not include basic.h and this requires that source files do include it.

That said, I think that we now use force-include to ensure basic.h is in all source files at the right position, so we should probably start linting that no files explicitly include basic.h. We could either retake SERVER-7504 for that or file a new ticket or do nothing.

Comment by Alex Neben [ 29/Aug/23 ]

This is in the opposite of SERVER-7504. I am going to close both tickets. mathias@mongodb.com and schwerin@mongodb.com can you two come to an agreement and reopen one of these?

Generated at Thu Feb 08 04:05:12 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.