[SERVER-24045] Refactor LiteParsedQuery and CanonicalQuery::canonicalize() Created: 04/May/16  Updated: 19/Apr/17  Resolved: 10/May/16

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: None
Fix Version/s: 3.3.6

Type: Improvement Priority: Major - P3
Reporter: Tess Avitabile (Inactive) Assignee: Tess Avitabile (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-23610 CanonicalQuery should own a CollatorI... Closed
Related
is related to SERVER-28787 Invariant failure with QueryOption_Aw... Closed
Backwards Compatibility: Fully Compatible
Sprint: Query 14 (05/13/16)
Participants:
Linked BF Score: 0

 Description   

Make the following changes to the LiteParsedQuery interface:

Expose LiteParsedQuery(NamespaceString nss) and validate().
Delete makeAsOpQuery() and makeAsFindCmd().
Create setters and getters for all members.

Additionally, remove all overloads of CanonicalQuery::canonicalize() except:
canonicalize(const QueryMessage&, const ExtensionsCallback&),
canonicalize(LiteParsedQuery*, const ExtenstionsCallback&), and
canonicalize(const CanonicalQuery&, MatchExpression* root, const ExtensionsCallback&).
Callers of all other overloads should construct a LiteParsedQuery.



 Comments   
Comment by Githook User [ 10/May/16 ]

Author:

{u'username': u'tessavitabile', u'name': u'Tess Avitabile', u'email': u'tess.avitabile@mongodb.com'}

Message: SERVER-24045 Refactor CanonicalQuery::canonicalize()
Branch: master
https://github.com/mongodb/mongo/commit/8f8043d6128813e9862b5a5c30a90d007d92c363

Comment by Githook User [ 06/May/16 ]

Author:

{u'username': u'tessavitabile', u'name': u'Tess Avitabile', u'email': u'tess.avitabile@mongodb.com'}

Message: SERVER-24045 Refactor LiteParsedQuery
Branch: master
https://github.com/mongodb/mongo/commit/dc5f741da617060e4531a1fe7ca7f110735ac2ee

Comment by Tess Avitabile (Inactive) [ 04/May/16 ]

Sure, I'll add that to the ticket.

Comment by David Storch [ 04/May/16 ]

Will this work include getting rid of unnecessary canonicalize() overloads? I think it should.

Generated at Thu Feb 08 04:05:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.