[SERVER-24067] TaskExecutor RemoteCommandCallbackArgs should include elapsedMS and metadata Created: 05/May/16  Updated: 13/Aug/16  Resolved: 03/Aug/16

Status: Closed
Project: Core Server
Component/s: Networking
Affects Version/s: None
Fix Version/s: 3.3.11

Type: Bug Priority: Major - P3
Reporter: Scott Hernandez (Inactive) Assignee: Waley Chen
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-24113 OplogFetcher getMore callback QueryRe... Closed
is related to SERVER-23134 Add FetcherWithRetries Closed
Backwards Compatibility: Major Change
Sprint: Repl 14 (05/13/16), Platforms 16 (06/24/16), Platforms 17 (07/15/16), Platforms 18 (08/05/16)
Participants:

 Description   

Currently TaskExecutor::RemoteCommandCallbackArgs::RemoteCommandCallbackArgs contains a response that is a StatusWith<RemoteCommandResponse> where you can only get the elapsed time on success, not the error cases.

We should always return the time, even on failures.
We should also return the metadata where we have it available (as in the case of command failures)

This is needed for retries and other operations done by the callers of scheduleRemoteCommand.



 Comments   
Comment by Githook User [ 12/Aug/16 ]

Author:

{u'username': u'DiannaHohensee', u'name': u'Dianna Hohensee', u'email': u'dianna.hohensee@10gen.com'}

Message: Reverting incorrect patch commit for SERVER-24368

Revert "SERVER-24368 Unit tests for collection range deleter"

This reverts commit 347ed5e82813b433fea01e78f9873ea2be7c91bf.

Revert "SERVER-24067 remove unnecessary brace initializer"

This reverts commit 913c7213d244dce5586bba03d295390856d58aab.
Branch: master
https://github.com/mongodb/mongo/commit/e464e8855e32f9571151662be3eb896ea496822a

Comment by Kyle Suarez [ 12/Aug/16 ]

The commit mentioned in this comment is a mistake; it actually refers to work for SERVER-24368.

Comment by Githook User [ 12/Aug/16 ]

Author:

{u'username': u'ksuarz', u'name': u'Kyle Suarez', u'email': u'kyle.suarez@mongodb.com'}

Message: SERVER-24067 remove unnecessary brace initializer
Branch: master
https://github.com/mongodb/mongo/commit/913c7213d244dce5586bba03d295390856d58aab

Comment by Githook User [ 04/Aug/16 ]

Author:

{u'username': u'ksuarz', u'name': u'Kyle Suarez', u'email': u'kyle.suarez@mongodb.com'}

Message: SERVER-24067 remove unnecessary brace initializer
Branch: master
https://github.com/mongodb/mongo/commit/ad86d29a2cc93144dd2a143feaac415aa062ab99

Comment by Githook User [ 03/Aug/16 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-24067 fixed missing library dependency in downconvert_find_and_getmore_commands
Branch: master
https://github.com/mongodb/mongo/commit/56a1190a092fb39b3bd5066023775e7b7622dab1

Comment by Githook User [ 03/Aug/16 ]

Author:

{u'username': u'ksuarz', u'name': u'Kyle Suarez', u'email': u'kyle.suarez@mongodb.com'}

Message: SERVER-24067 remove pessimizing move
Branch: master
https://github.com/mongodb/mongo/commit/e3429206ee8f89f3cfcadc2199fef8f11db3861d

Comment by Githook User [ 03/Aug/16 ]

Author:

{u'username': u'WaleyChen', u'name': u'Waley Chen', u'email': u'waleycz@gmail.com'}

Message: SERVER-24067 TaskExecutor RemoteCommandCallbackArgs should include elapsedMS and metadata

lint fix
Branch: master
https://github.com/mongodb/mongo/commit/52113a58ea6148cad16257fe17a4da6476ff0a27

Comment by Githook User [ 03/Aug/16 ]

Author:

{u'username': u'WaleyChen', u'name': u'Waley Chen', u'email': u'waleycz@gmail.com'}

Message: SERVER-24067 TaskExecutor RemoteCommandCallbackArgs should include elapsedMS and metadata

Accidentally added this recently deleted file in the last commit:
"SERVER-24067 TaskExecutor RemoteCommandCallbackArgs should include elapsedMS and metadata"
Branch: master
https://github.com/mongodb/mongo/commit/17f04c75a9ce572189a40e9390dbcfd4b7a51484

Comment by Githook User [ 03/Aug/16 ]

Author:

{u'username': u'WaleyChen', u'name': u'Waley Chen', u'email': u'waleycz@gmail.com'}

Message: SERVER-24067 TaskExecutor RemoteCommandCallbackArgs should include elapsedMS and metadata

Accidentally added this recently deleted file in the last commit:
"SERVER-24067 TaskExecutor RemoteCommandCallbackArgs should include elapsedMS and metadata"
Branch: master
https://github.com/mongodb/mongo/commit/17f04c75a9ce572189a40e9390dbcfd4b7a51484

Comment by Githook User [ 03/Aug/16 ]

Author:

{u'username': u'WaleyChen', u'name': u'Waley Chen', u'email': u'waleycz@gmail.com'}

Message: SERVER-24067 TaskExecutor RemoteCommandCallbackArgs should include elapsedMS and metadata
Branch: master
https://github.com/mongodb/mongo/commit/05e1c33649e08ec3736121254da7b29a73934788

Generated at Thu Feb 08 04:05:17 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.