[SERVER-24126] Add step to _cfgsvrAddShard command where it inserts the shardIdentity document to the new shard Created: 10/May/16  Updated: 14/Jul/16  Resolved: 10/Jun/16

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 3.3.9

Type: Task Priority: Major - P3
Reporter: Spencer Brody (Inactive) Assignee: Esha Maharishi (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-24468 add test to check that minOpTimeUpdat... Closed
related to SERVER-24527 add test to ensure shard undergoes sh... Closed
is related to SERVER-24464 Write auth test cases for the '_confi... Closed
Backwards Compatibility: Fully Compatible
Sprint: Sharding 15 (06/03/16), Sharding 16 (06/24/16)
Participants:

 Comments   
Comment by Githook User [ 13/Jun/16 ]

Author:

{u'name': u'Esha Maharishi', u'email': u'esha.maharishi@mongodb.com'}

Message: SERVER-24464 re-apply after revert and fix for SERVER-24126
Branch: master
https://github.com/mongodb/mongo/commit/3ad77a8034ace30ede9b60526d951fe7386c62e4

Comment by Githook User [ 13/Jun/16 ]

Author:

{u'name': u'Esha Maharishi', u'email': u'esha.maharishi@mongodb.com'}

Message: SERVER-24126 fix shared library compile
Branch: master
https://github.com/mongodb/mongo/commit/677c25dbc453e90c0d2ef6b77b4284ea34c1b949

Comment by Githook User [ 10/Jun/16 ]

Author:

{u'name': u'Esha Maharishi', u'email': u'esha.maharishi@mongodb.com'}

Message: Revert "SERVER-24126 Add step to _cfgsvrAddShard command where it inserts the shardIdentity document to the new shard"

This reverts commit 1e26998e7fda52c226385fae4069ebbc384c294a.
Branch: master
https://github.com/mongodb/mongo/commit/029938758e4f9c7079e2363bf5e56c1452c20426

Comment by Githook User [ 10/Jun/16 ]

Author:

{u'name': u'Esha Maharishi', u'email': u'esha.maharishi@mongodb.com'}

Message: SERVER-24126 Add step to _cfgsvrAddShard command where it inserts the shardIdentity document to the new shard
Branch: master
https://github.com/mongodb/mongo/commit/1e26998e7fda52c226385fae4069ebbc384c294a

Comment by Spencer Brody (Inactive) [ 31/May/16 ]

Given how easy it is to add a test in commands_lib.js, seems like we might as well. There's really no downside to doing it.

Comment by Kamran K. [ 31/May/16 ]

My two cents: Is there an existing test that would fail if _cfgsvrAddShard's checkAuthForCommand code were changed to always return Status::OK()? If not, then it seems prudent to add a test to commands_lib.js.

Comment by Spencer Brody (Inactive) [ 31/May/16 ]

The privileges it requires should definitely be the 'internal' action on the cluster resource. Whether or not we add a test to commands_lib.js I don't feel strongly about. We're inconsistent currently about whether we test internal-only commands there. andreas.nilsson

Comment by Esha Maharishi (Inactive) [ 31/May/16 ]

Todo:

How should authorization be addressed for this new, internal command? Do we need to add a test for the _configsvrAddShard command to https://github.com/mongodb/mongo/blob/master/jstests/auth/lib/commands_lib.js?

As called out by kamran.khan, dan@10gen.com.

Generated at Thu Feb 08 04:05:27 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.