[SERVER-24126] Add step to _cfgsvrAddShard command where it inserts the shardIdentity document to the new shard Created: 10/May/16 Updated: 14/Jul/16 Resolved: 10/Jun/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 3.3.9 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Spencer Brody (Inactive) | Assignee: | Esha Maharishi (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Sprint: | Sharding 15 (06/03/16), Sharding 16 (06/24/16) | ||||||||||||||||
| Participants: | |||||||||||||||||
| Comments |
| Comment by Githook User [ 13/Jun/16 ] |
|
Author: {u'name': u'Esha Maharishi', u'email': u'esha.maharishi@mongodb.com'}Message: |
| Comment by Githook User [ 13/Jun/16 ] |
|
Author: {u'name': u'Esha Maharishi', u'email': u'esha.maharishi@mongodb.com'}Message: |
| Comment by Githook User [ 10/Jun/16 ] |
|
Author: {u'name': u'Esha Maharishi', u'email': u'esha.maharishi@mongodb.com'}Message: Revert " This reverts commit 1e26998e7fda52c226385fae4069ebbc384c294a. |
| Comment by Githook User [ 10/Jun/16 ] |
|
Author: {u'name': u'Esha Maharishi', u'email': u'esha.maharishi@mongodb.com'}Message: |
| Comment by Spencer Brody (Inactive) [ 31/May/16 ] |
|
Given how easy it is to add a test in commands_lib.js, seems like we might as well. There's really no downside to doing it. |
| Comment by Kamran K. [ 31/May/16 ] |
|
My two cents: Is there an existing test that would fail if _cfgsvrAddShard's checkAuthForCommand code were changed to always return Status::OK()? If not, then it seems prudent to add a test to commands_lib.js. |
| Comment by Spencer Brody (Inactive) [ 31/May/16 ] |
|
The privileges it requires should definitely be the 'internal' action on the cluster resource. Whether or not we add a test to commands_lib.js I don't feel strongly about. We're inconsistent currently about whether we test internal-only commands there. andreas.nilsson |
| Comment by Esha Maharishi (Inactive) [ 31/May/16 ] |
|
Todo: How should authorization be addressed for this new, internal command? Do we need to add a test for the _configsvrAddShard command to https://github.com/mongodb/mongo/blob/master/jstests/auth/lib/commands_lib.js? As called out by kamran.khan, dan@10gen.com. |