[SERVER-24355] clang_format leaves temporary files around after a reformat Created: 02/Jun/16 Updated: 05/Jul/16 Resolved: 09/Jun/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | 3.3.8 |
| Fix Version/s: | 3.3.9 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Kaloian Manassiev | Assignee: | Mark Benvenuto |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Sprint: | Platforms 16 (06/24/16) |
| Participants: |
| Description |
|
After upgrading clang_format to version 3.8 I noticed that each time it formats a source file it leaves a .TMP file around. For example:
Having these files around makes it difficult to run git add src/., because they will get added to the source tree as well. |
| Comments |
| Comment by Githook User [ 09/Jun/16 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 08/Jun/16 ] |
|
Author: {u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}Message: |
| Comment by Mark Benvenuto [ 07/Jun/16 ] |
|
I can repro the issue with clang-format 3.8. It does not repro for me with master branch. Here is a related upstream bug report: https://llvm.org/bugs/show_bug.cgi?id=26286 |
| Comment by Andy Schwerin [ 03/Jun/16 ] |
|
I think it would be a fine solution to ignore.TMP files. On Fri, Jun 3, 2016 at 10:15 AM Kaloian Manassiev (JIRA) <jira@mongodb.org> |
| Comment by Kaloian Manassiev [ 03/Jun/16 ] |
|
I was hoping that this is just some setting, which can be passed to the underlying LLVM module, but I see that there are some LLVM bugs with similar description. I am fine with just adding .TMP to .gitignore and if it is acceptable solution I can make the change. |
| Comment by Andy Schwerin [ 03/Jun/16 ] |
|
kaloian.manassiev, would it suffice to add *.TMP (or whatever the globbing rules are) to the .gitignore file? |