[SERVER-24374] Decimal128 constructors taking integers should be constexpr Created: 02/Jun/16 Updated: 09/Jul/19 Resolved: 28/Jun/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.1 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Mathias Stearn | Assignee: | Billy Donahue |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Sprint: | Dev Tools 2019-06-03, Dev Tools 2019-06-17, Dev Tools 2019-07-01 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Linked BF Score: | 28 | ||||||||||||||||
| Description |
|
This would allow Decimal128(10) to be a true compile-time constant. |
| Comments |
| Comment by Githook User [ 27/Jun/19 ] | |||||
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message:
| |||||
| Comment by Billy Donahue [ 24/Jun/19 ] | |||||
| Comment by Billy Donahue [ 24/Jun/19 ] | |||||
|
Dynamic link complications written up in SERVER-41835. | |||||
| Comment by Andrew Morrow (Inactive) [ 18/Jun/19 ] | |||||
|
billy.donahue - Would you mind writing a new ticket describing these findings so that we can undertake a fix? | |||||
| Comment by Billy Donahue [ 17/Jun/19 ] | |||||
|
Ran into a not-quite-diagnosed issue with the LIBDEPS_PRIVATE change in the original attempt at this ticket, It means that the system's libgcc, which provides its own intelfp names, can seep into dynamic builds of the decimal128_test. We're doing something wrong, Here's a grep for _bid128_to_int32_rnint, among the 'nm' output for each dependency in the 'ldd' output from decimal128_test,
We should solve this problem but it doesn't need to block the implementation of constexpr Decimal128 constructors. | |||||
| Comment by Githook User [ 16/Jun/19 ] | |||||
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: Revert " This reverts commit e039271638d6dba34e5b64834e3f12e87aeb6455. | |||||
| Comment by Githook User [ 16/Jun/19 ] | |||||
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: reverts fab9fde6ba which reverted 668100df79 | |||||
| Comment by Billy Donahue [ 14/Jun/19 ] | |||||
|
Code Review ( | |||||
| Comment by Githook User [ 13/Jun/19 ] | |||||
|
Author: {'name': 'Blake Oler', 'email': 'blake.oler@mongodb.com', 'username': 'BlakeIsBlake'}Message: Revert " This reverts commit 668100df7982fd1ae3777fcf069de13253a05133. | |||||
| Comment by Githook User [ 13/Jun/19 ] | |||||
|
Author: {'name': 'A. Jesse Jiryu Davis', 'email': 'jesse@mongodb.com', 'username': 'ajdavis'}Message: |