[SERVER-24512] Ensure complete end-to-end testing for collation Created: 09/Jun/16  Updated: 19/Nov/16  Resolved: 19/Oct/16

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: None
Fix Version/s: 3.4.0-rc1

Type: Task Priority: Major - P3
Reporter: David Storch Assignee: David Storch
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Query 2016-10-31
Participants:

 Description   

Although we're adding integration and unit tests as we develop the collation feature, we should use this ticket to look for any gaps in coverage, including using code coverage analysis.



 Comments   
Comment by David Storch [ 19/Oct/16 ]

Resolving as Fixed, since there is no further work for this ticket. I did take the following steps to ensure good test coverage for collation:

  • Ran the experiment described by Ian above. Specifically, I ran tests in jstests/core where db.createCollection() and db.collection.insert() were overridden to create a collection with {collation: {locale: "fr_CA"}}. 65 tests failed, but I reviewed them and all were false positives. I also ran the experiment using {collation: {locale: "simple"}}. In this case, 7 tests failed and all were false positives.
  • Reviewed code coverage results. The latest run shows 90% line coverage in db/query/collation. Many of the lines which are not covered are expected to be dead code (e.g. MONGO_UNREACHABLE). I also took a look at db/query, db/exec/, db/pipeline, and db/ops to see if I could find any interesting missing coverage related to collation.
  • Reviewed subtasks to see if any collation-related SERVER ticket was inadequately tested.
Comment by Githook User [ 14/Oct/16 ]

Author:

{u'username': u'dstorch', u'name': u'David Storch', u'email': u'david.storch@10gen.com'}

Message: SERVER-24512 remove dead Interval code
Branch: master
https://github.com/mongodb/mongo/commit/dacb3f05f69568b651c0ba620fa075e5c902e177

Comment by Ian Whalen (Inactive) [ 15/Sep/16 ]

This should probably include an experiment to see if a jscore collation passthrough (which overrides collection creation to always use locale:"en" as the default collation) was useful.

Generated at Thu Feb 08 04:06:34 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.