|
Resolving as Fixed, since there is no further work for this ticket. I did take the following steps to ensure good test coverage for collation:
- Ran the experiment described by Ian above. Specifically, I ran tests in jstests/core where db.createCollection() and db.collection.insert() were overridden to create a collection with {collation: {locale: "fr_CA"}}. 65 tests failed, but I reviewed them and all were false positives. I also ran the experiment using {collation: {locale: "simple"}}. In this case, 7 tests failed and all were false positives.
- Reviewed code coverage results. The latest run shows 90% line coverage in db/query/collation. Many of the lines which are not covered are expected to be dead code (e.g. MONGO_UNREACHABLE). I also took a look at db/query, db/exec/, db/pipeline, and db/ops to see if I could find any interesting missing coverage related to collation.
- Reviewed subtasks to see if any collation-related SERVER ticket was inadequately tested.
|