[SERVER-24534] Commands that accept user predicates should use collection default collation Created: 13/Jun/16 Updated: 13/Aug/16 Resolved: 27/Jul/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Querying |
| Affects Version/s: | None |
| Fix Version/s: | 3.3.11 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | J Rassi | Assignee: | Max Hirschhorn |
| Resolution: | Done | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Sprint: | Query 18 (08/05/16) | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
The following commands do not accept a user collation, but the predicates they accept should respect the default collation (if the collection has one):
|
| Comments |
| Comment by Githook User [ 27/Jul/16 ] |
|
Author: {u'username': u'visemet', u'name': u'Max Hirschhorn', u'email': u'max.hirschhorn@mongodb.com'}Message: Tests that the "cloneCollection", "cloneCollectionAsCapped", |
| Comment by David Storch [ 20/Jul/16 ] |
Since stageDebug is test only, there is no need to have it inherit the default collation now. If in the future we find this to be useful for writing test cases, we can do it at that time.
Agreed, we should leave as is.
Agreed, I think chunk management operations should always use whatever collation the shard key has, so I don't see a future in which we will need a collation parameter on these commands. |
| Comment by Max Hirschhorn [ 20/Jul/16 ] |
|
As part of this audit, I looked through the list of commands supported by MongoDB and searched for callers of MatchExpressionParser::parse() as well as users of the Matcher class. I think the "stageDebug" command is the only one not mentioned already that we could consider having inherit the default collation of the collection. david.storch, do you think that would be useful for any testing we plan to do?
Per my conversation with Dave, I'm inclined to convert this ticket into a task for testing that the "cloneCollection", "cloneCollectionAsCapped", "convertToCapped", and "copydb" commands all inherit the default collation of the collection when the associated collection is copied. |
| Comment by J Rassi [ 13/Jun/16 ] |
|
Ah, of course. I've struck those above. |
| Comment by Andy Schwerin [ 13/Jun/16 ] |
|
currentOp and listCollections aren't run over a collection, so I am not certain that there is a meaningful collection-default collation to use. |
| Comment by J Rassi [ 13/Jun/16 ] |
|
I'm assuming that split, moveChunk, and geoSearch should not be included in the above list, but they should at least be given passing consideration when this ticket is triaged. |