[SERVER-24588] conf.Finish() is missing in src/third_party/wiredtiger/SConscript Created: 15/Jun/16 Updated: 20/Nov/16 Resolved: 15/Jun/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | 3.2.7, 3.3.8 |
| Fix Version/s: | 3.2.8, 3.3.9 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Igor Solodovnikov | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | code-only | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Backport Completed: | |
| Steps To Reproduce: | Add Configure(env) call to any SConscript file which is executed after src/third_party/wiredtiger/SConscript. For example add it to src/mongo/db/storage/rocks/SConscript. |
| Sprint: | Platforms 16 (06/24/16) |
| Participants: |
| Description |
|
There is a call to Configure(env) in src/third_party/wiredtiger/SConscript. But there is no cleanup call conf.Finish() in that file.
|
| Comments |
| Comment by Githook User [ 22/Jun/16 ] |
|
Author: {u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}Message: (cherry picked from commit ae388b954d20caa224b136d7aaf18241abc6b2b5) |
| Comment by Igor Solodovnikov [ 15/Jun/16 ] |
|
acm thank you for quick fix! |
| Comment by Githook User [ 15/Jun/16 ] |
|
Author: {u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}Message: |
| Comment by Andrew Morrow (Inactive) [ 15/Jun/16 ] |
|
Hi igorsol - Yes, that is definitely an error, we will get it fixed. Thanks for the detailed bug report. As you note, we were getting away with this only because this happened to be the last Configure object we create in our builds, so leaving it unclosed did not have any adverse effects for us. |