[SERVER-24635] Remove duplicate fassert w/status function Created: 17/Jun/16  Updated: 06/Apr/18  Resolved: 08/Mar/18

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 3.7.3

Type: Task Priority: Minor - P4
Reporter: Scott Hernandez (Inactive) Assignee: Benety Goh
Resolution: Done Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-33659 add no-trace variant fassertStatusOK ... Closed
related to SERVER-34364 add Status support to invariant() Closed
Backwards Compatibility: Fully Compatible
Sprint: Repl 2018-03-26
Participants:

 Description   

We have these two, with the same impl.:

inline void fassertStatusOK(int msgid, const Status& s);
inline void fassert(int msgid, const Status& status);

We should also make sure when we remove one they are consistent with the StatusWith and no-trace versions.



 Comments   
Comment by Githook User [ 08/Mar/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-24635 remove fassertStatusOK

This is redundant now that fassert supports both Status and StatusWith.
Branch: master
https://github.com/mongodb/mongo/commit/1441f6000823f3889d0f7f90fe3f3f6b67fed0ac

Comment by Benety Goh [ 07/Mar/18 ]

At this point, all references to fassertStatusOK in master have been replaced by fassert. We will be removing fassertStatusOK from assert_util.h shortly. Until then, no new references to fassertStatusOK() should be introduced to the codebase.

Comment by Githook User [ 07/Mar/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-24635 replace references to fassertStatusOK with fassert
Branch: master
https://github.com/mongodb/mongo/commit/0bc90017e2563ed7432d56051483763c91d28025

Comment by Githook User [ 07/Mar/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-24635 replace references to fassertStatusOK with fassert
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/025ca19ab7ab8f48d1e6054d064cc7993f33916e

Generated at Thu Feb 08 04:06:58 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.