[SERVER-24702] Remove remnants of ShardingCatalogManagerImpl from ShardingTestFixture Created: 21/Jun/16 Updated: 19/Nov/16 Resolved: 06/Sep/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 3.3.14 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Spencer Brody (Inactive) | Assignee: | Esha Maharishi (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Sharding 18 (08/05/16), Sharding 2016-08-29, Sharding 2016-09-19 | ||||||||
| Participants: | |||||||||
| Description |
|
Currently ShardingCatalogTestFixture sets up both a ShardingCatalogClientImpl and a ShardingCatalogManagerImpl. The config shard, however, is still a ShardRemote. That means that any tests using ShardingCatalogManagerImpl will be acting as though the ShardingCatalogManagerImpl were talking to a remote config server, which is never what will happen in non-test code. We also have ConfigServerTestFixture, which also sets up both a ShardingCatalogClientImpl and a ShardingCatalogManagerImpl, but with the config server as a LocalShard. This is closer to how things work in prod code. Thus all tests that use ShardingCatalogManagerImpl should be converted to use ConfigServerTestFixture instead of ShardingCatalogTestFixture. We should also probably then rename ShardingCatalogTestFixture to ShardingCatalogClientTestFixture. |
| Comments |
| Comment by Githook User [ 06/Sep/16 ] |
|
Author: {u'name': u'Esha Maharishi', u'email': u'esha.maharishi@mongodb.com'}Message: |
| Comment by Spencer Brody (Inactive) [ 23/Aug/16 ] |
|
Hopefully this can fall out from the work esha.maharishi is doing to clean up our unit test fixtures. |
| Comment by Spencer Brody (Inactive) [ 12/Aug/16 ] |
|
Leaving open until we fully remove the now-unused members from ShardingTestFixture |
| Comment by Spencer Brody (Inactive) [ 12/Aug/16 ] |
|
Fixed by https://github.com/mongodb/mongo/commit/3ffcc4b4a105ccacb6c8d8863d44f88338395b3a |
| Comment by Spencer Brody (Inactive) [ 21/Jun/16 ] |
|
As of right now I believe the only tests that are incorrectly in ShardingCatalogTestFixture but should be in ConfigServerTestFixture are the addShard tests. |