[SERVER-24842] ShardingStateRecovery::recover cleanup should not wait for replication Created: 29/Jun/16  Updated: 21/Nov/16  Resolved: 05/Jul/16

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: 3.2.7, 3.3.9
Fix Version/s: 3.2.9, 3.3.10

Type: Bug Priority: Major - P3
Reporter: Kaloian Manassiev Assignee: Kaloian Manassiev
Resolution: Done Votes: 0
Labels: code-only
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Completed:
Sprint: Sharding 17 (07/15/16)
Participants:

 Description   

Upon success the ShardingStateRecovery::recover call tries to cleanup the recovery document and uses majority write concern to do that. This method is called at the end of draining mode, but still under the global X lock and as a result it will never replicate and will stall leaving the draining mode.

Instead, ShardingStateRecovery::recover should use local-only write concern.



 Comments   
Comment by Githook User [ 29/Jul/16 ]

Author:

{u'username': u'visemet', u'name': u'Max Hirschhorn', u'email': u'max.hirschhorn@mongodb.com'}

Message: SERVER-24842 Fix lint by removing trailing whitespace.
Branch: v3.2
https://github.com/mongodb/mongo/commit/b55edf72213f77579fc024740e5930eaaaa42463

Comment by Githook User [ 29/Jul/16 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-24842 ShardingStateRecovery::recover cleanup should not wait for replication
Branch: v3.2
https://github.com/mongodb/mongo/commit/ac0e731677e4c377917acaf95030873d0162df17

Comment by Githook User [ 28/Jul/16 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: Revert "SERVER-24842 ShardingStateRecovery::recover cleanup should not wait for replication"

This reverts commit 53f346b85633e206f00b3c5cdd702a7ef3e90095.
Branch: v3.2
https://github.com/mongodb/mongo/commit/d0417c9239b0993f9e29312e060a3b0300db4c5b

Comment by Githook User [ 28/Jul/16 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-24842 ShardingStateRecovery::recover cleanup should not wait for replication
Branch: v3.2
https://github.com/mongodb/mongo/commit/53f346b85633e206f00b3c5cdd702a7ef3e90095

Comment by Githook User [ 05/Jul/16 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-24842 ShardingStateRecovery::recover cleanup should not wait for replication
Branch: master
https://github.com/mongodb/mongo/commit/15d99df73f944a56bc76286655f36be034bdbbf8

Generated at Thu Feb 08 04:07:33 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.