[SERVER-24953] Coverity analysis defect 99693: Big parameter passed by value Created: 08/Jul/16  Updated: 06/Dec/22  Resolved: 06/Jan/20

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Coverity Collector User Assignee: Backlog - Replication Team
Resolution: Won't Fix Votes: 0
Labels: coverity
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Replication
Operating System: ALL
Sprint: Repl 17 (07/15/16), Repl 18 (08/05/16)
Participants:

 Description   

A large function call parameter or exception catch statement is passed by value

Defect 99693 (STATIC_C)
Checker PASS_BY_VALUE (subcategory none)
File: /src/mongo/db/repl/data_replicator.cpp
Function mongo::repl::DataReplicator::DataReplicator(mongo::repl::DataReplicatorOptions, std::unique_ptr<mongo::repl::DataReplicatorExternalState, std::default_delete<mongo::repl::DataReplicatorExternalState>>, mongo::repl::ReplicationExecutor *, mongo::repl::StorageInterface *)
/src/mongo/db/repl/data_replicator.cpp, line: 240
Passing parameter opts of type "mongo::repl::DataReplicatorOptions" (size 384 bytes) by value.

        DataReplicatorOptions opts,



 Comments   
Comment by Judah Schvimer [ 06/Jan/20 ]

This exists in the InitialSyncer now, but still exists. This isn't a performance critical area of code though, so closing "Won't Fix".

Generated at Thu Feb 08 04:07:52 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.