[SERVER-24968] Make sure we don't retry non-idempotent writes on "NotMaster" errors that actually did a write Created: 09/Jul/16 Updated: 26/Aug/16 Resolved: 25/Aug/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication, Sharding |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Spencer Brody (Inactive) | Assignee: | Siyuan Zhou |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Sprint: | Repl 18 (08/05/16), Repl 2016-08-29 | ||||||||
| Participants: | |||||||||
| Description |
|
Generally if you get a NotMaster error back from an attempted write you know that nothing was written. With |
| Comments |
| Comment by Siyuan Zhou [ 25/Aug/16 ] |
|
Resolve as a dup to |
| Comment by Siyuan Zhou [ 19/Jul/16 ] |
|
schwerin, yes, that's the plan. I'll audit all uses of NotMaster. Updated that ticket's description. |
| Comment by Andy Schwerin [ 18/Jul/16 ] |
|
siyuan.zhou, when you implement |
| Comment by Andy Schwerin [ 11/Jul/16 ] |
|
We need to return a different error code if the step down occurs after vs before the wtite. NotMaster should always mean "no write occurred." I think there may be another ticket for this. Check with siyuan.zhou . |
| Comment by Spencer Brody (Inactive) [ 09/Jul/16 ] |
|
Can this also cause us to return NotMaster to end users when a write actually happened, because the connection from the mongos to the shard will be marked internal and not be closed on stepdown? |