[SERVER-25056] ImplScope should check interruptability against an opctx Created: 13/Jul/16 Updated: 08/Jan/24 Resolved: 09/Aug/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | JavaScript |
| Affects Version/s: | None |
| Fix Version/s: | 3.2.10, 3.3.11 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Mira Carey | Assignee: | Matt Cotter |
| Resolution: | Done | Votes: | 0 |
| Labels: | code-only | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Operating System: | ALL | ||||
| Backport Completed: | |||||
| Sprint: | Platforms 18 (08/05/16), Platforms 2016-08-26 | ||||
| Participants: | |||||
| Linked BF Score: | 0 | ||||
| Description |
|
The implscope currently get's a kill flag set which it uses to detect interruptions. This seems to be a bit racy, in that we've managed to miss interrupts historically (and may be in some narrow races today). It would be less complicated and more durable if we just access the opctx and check for interruptions in the interrupt callback for spidermonkey. This will prevent any long running javascript operation from ever missing a killop. |
| Comments |
| Comment by Matt Cotter [ 30/Aug/16 ] |
|
Done! |
| Comment by Githook User [ 30/Aug/16 ] |
|
Author: {u'username': u'Machyne', u'name': u'Matt Cotter', u'email': u'matt.cotter@mongodb.com'}Message: (cherry picked from commit 9ca2c6dcc96cf826b0ef06a8cb1590ec2bcaa8a1) |
| Comment by Githook User [ 09/Aug/16 ] |
|
Author: {u'username': u'Machyne', u'name': u'Matt Cotter', u'email': u'matt.cotter@mongodb.com'}Message: |