[SERVER-25311] mongos count command should use CountRequest Created: 27/Jul/16 Updated: 06/Dec/22 Resolved: 26/Feb/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Querying, Sharding |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | David Storch | Assignee: | Backlog - Query Team (Inactive) |
| Resolution: | Done | Votes: | 1 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Query
|
||||||||
| Participants: | |||||||||
| Description |
|
The mongod implementation of the count command parses the request using a utility called CountRequest (see https://github.com/mongodb/mongo/blob/r3.3.10/src/mongo/db/commands/count_cmd.cpp#L141). The mongos implementation, however, has old parsing code which was never ported to use CountRequest: https://github.com/mongodb/mongo/blob/r3.3.10/src/mongo/s/commands/cluster_count_cmd.cpp#L110-L128 This is bad because it means there is more code to maintain and makes it more likely that the two implementations will get out of sync. Therefore, the mongos implementation should be updated to also use CountRequest. |
| Comments |
| Comment by David Storch [ 26/Feb/20 ] |
|
Closing as "Gone Away", since it appears that this was already done by katherine.wu as part of |