[SERVER-25333] Clean up MigrationDestinationManager Created: 29/Jul/16 Updated: 23/Sep/19 Resolved: 20/Jul/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.2, 4.1.2 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Dianna Hohensee (Inactive) | Assignee: | Blake Oler |
| Resolution: | Done | Votes: | 0 |
| Labels: | todo_in_code | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||||||
| Backport Requested: |
v4.0
|
||||||||||||||||||||||||||||||||
| Sprint: | Sharding 2018-06-04, Sharding 2018-06-18, Sharding 2018-07-16, Sharding 2018-07-30 | ||||||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||||||
| Linked BF Score: | 0 | ||||||||||||||||||||||||||||||||
| Description |
|
Three things: fromShard is a connection string – misleading. _recvStartChunk should get a ShardId rather than a connection string, then the MigrationDestinationManager can get connection strings from the ShardRegistry. There's a ScopedDbConnection conn object that shouldn't be used anymore: use the ShardRegistry and Shard. Start actually using StartChunkCloneRequest::createFromCommand, which is currently used no where. Generally clean up the MigrationDestinationManager – e.g., we have "_from = fromShard" local variable, but pass fromShard through functions anyway. |
| Comments |
| Comment by Githook User [ 21/Aug/18 ] |
|
Author: {'name': 'Blake Oler', 'email': 'blake.oler@mongodb.com', 'username': 'BlakeIsBlake'}Message: (cherry picked from commit 96ef338b6a62eaf0761242b0c040708f3f3e5d6e) |
| Comment by Githook User [ 21/Aug/18 ] |
|
Author: {'name': 'Blake Oler', 'email': 'blake.oler@mongodb.com', 'username': 'BlakeIsBlake'}Message: (cherry picked from commit e117102282d4d8bc0352429cf67b2d01754f4ad1) |
| Comment by Githook User [ 21/Aug/18 ] |
|
Author: {'name': 'Blake Oler', 'email': 'blake.oler@mongodb.com', 'username': 'BlakeIsBlake'}Message: (cherry picked from commit 343bd29619461dfd38f2e8d3fd355f7c625a971b) |
| Comment by Githook User [ 20/Jul/18 ] |
|
Author: {'name': 'Blake Oler', 'email': 'blake.oler@mongodb.com', 'username': 'BlakeIsBlake'}Message: |
| Comment by Githook User [ 02/Jul/18 ] |
|
Author: {'username': 'BlakeIsBlake', 'name': 'Blake Oler', 'email': 'blake.oler@mongodb.com'}Message: |
| Comment by Githook User [ 28/Jun/18 ] |
|
Author: {'username': 'BlakeIsBlake', 'name': 'Blake Oler', 'email': 'blake.oler@mongodb.com'}Message: |