[SERVER-25459] Create command should reject unknown options Created: 05/Aug/16  Updated: 28/Jan/19  Resolved: 03/Oct/16

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: 3.3.10
Fix Version/s: 3.4.0-rc1

Type: Improvement Priority: Major - P3
Reporter: Kyle Suarez Assignee: Tess Avitabile (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Documented
is documented by DOCS-9204 3.4 release notes compatibility chang... Closed
Related
related to SERVER-26571 cannot upgrade database created in 2.... Closed
related to SERVER-26490 Whitelist usePowerOf2Sizes option to ... Closed
is related to SERVER-39231 Create command should reject incorrec... Closed
Backwards Compatibility: Fully Compatible
Sprint: Query 2016-10-10
Participants:

 Description   

The create command should reject any unknown options passed to it. Currently, unknown options are ignored.

We could probably implement this by adding a catch-all case to the if statement in collection_options.cpp.



 Comments   
Comment by Githook User [ 03/Oct/16 ]

Author:

{u'username': u'tessavitabile', u'name': u'Tess Avitabile', u'email': u'tess.avitabile@mongodb.com'}

Message: SERVER-25459 Create command should reject unknown options
Branch: master
https://github.com/mongodb/mongo/commit/ba6ba85f0546ae689aec9e7a5526bd14ff2154b6

Comment by Tess Avitabile (Inactive) [ 29/Sep/16 ]

This change will only reject top-level unknown options to the create command, and will not look inside the storageEngine option. The storageEngine option is validated by each node in the replica set here, since userCreateNS() is called from applyOps, so each node can validate the storageEngine option according to its storage engine.

Comment by Eric Milkie [ 05/Aug/16 ]

What if you pass collection options that are only valid on some storage engines, and you are running on a mixed-storage-engine replica set?

Generated at Thu Feb 08 04:09:14 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.