[SERVER-25464] Regenerate js-confdefs.h for Windows now that we're using VS2015 Created: 05/Aug/16  Updated: 05/Apr/17  Resolved: 10/Aug/16

Status: Closed
Project: Core Server
Component/s: JavaScript
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Max Hirschhorn Assignee: Mark Benvenuto
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
Backwards Compatibility: Fully Compatible
Sprint: Platforms 18 (08/05/16), Platforms 2016-08-26
Participants:
Linked BF Score: 0

 Description   

The preprocessor definitions are out date. For example, HAVE_LOG2 isn't defined even though the log2() function is available in VS2015.



 Comments   
Comment by Mark Benvenuto [ 08/Aug/16 ]

The issue is that this check:

AC_CHECK_FUNCS([log2 log1p expm1 sqrt1pm1 acosh asinh atanh cbrt])}}

is not run on MSVC because it is skipped on MSVC.

This fix is define a hard coded define for MSVC 2015 similar to hypot. The solution is to just define HAVE_LOG2 and other math functions in js-confdefs.h.

Upstream removed these checks in https://bugzilla.mozilla.org/show_bug.cgi?id=933257 and https://hg.mozilla.org/mozilla-central/rev/b053ad6763d6 to fix another problem.

Generated at Thu Feb 08 04:09:15 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.