[SERVER-25480] MmapV1ExtentManager::printFreeList is unused and should be removed Created: 08/Aug/16  Updated: 19/Jan/17  Resolved: 15/Aug/16

Status: Closed
Project: Core Server
Component/s: MMAPv1
Affects Version/s: None
Fix Version/s: 3.3.12

Type: Task Priority: Trivial - P5
Reporter: Jianghua Yang Assignee: Backlog - Tuning Team
Resolution: Done Votes: 0
Labels: bkp
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Sprint: Repl 18 (08/05/16), Repl 2016-08-29
Participants:

 Description   

The MmapV1ExtentManager::printFreeList method was initially written for MMAP V1 debugging purposes, but has not been used since 3.0.



 Comments   
Comment by Kaloian Manassiev [ 15/Aug/16 ]

Hi yjhjstz, thank you for your contribution. It has been pushed to the master branch.

Best regards,
-Kal.

Comment by Githook User [ 15/Aug/16 ]

Author:

{u'name': u'jianghua.yjh', u'email': u'jianghua.yjh@alibaba-inc.om'}

Message: SERVER-25480 Remove unused MmapV1ExtentManager::printFreeList

Closes #1105

Signed-off-by: Kaloian Manassiev <kaloian.manassiev@mongodb.com>
Branch: master
https://github.com/mongodb/mongo/commit/4755dfd9e068ea77081b8bda37bcc64ff9b47cd7

Comment by Jianghua Yang [ 08/Aug/16 ]

Hi @Kaloian Manassiev , thanks for you reply.

I will send a pr to just remove it.

https://github.com/mongodb/mongo/pull/1105

Comment by Kaloian Manassiev [ 08/Aug/16 ]

Hi yjhjstz,

Thank you for bringing this to our attention. You are completely correct that the printFreeList method is not thread safe. It used to be called as part of another routine, which already held the collection S lock. As of version 3.0 this method is no longer necessary and we should just remove it.

I am going to change the title slightly and if you still have interest, we would be happy to accept a pull request, which removes it.

Thank you again.

Best regards,
-Kal.

Comment by Jianghua Yang [ 08/Aug/16 ]

may I send a PR?

Generated at Thu Feb 08 04:09:18 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.