[SERVER-25727] Only lint changed files Created: 22/Aug/16  Updated: 26/Oct/19  Resolved: 25/Oct/19

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Improvement Priority: Major - P3
Reporter: Scott Hernandez (Inactive) Assignee: Mathew Robinson (Inactive)
Resolution: Done Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-40474 Run linting out of scons process Closed
Backwards Compatibility: Fully Compatible
Sprint: Dev Tools 2019-10-07, Dev Tools 2019-10-21, Dev Platform 2019-11-04
Participants:

 Description   

We can reduce build times by only having list/eslint process changed files (like in the current commit, or working directory).



 Comments   
Comment by Githook User [ 24/Oct/19 ]

Author:

{'name': 'Mathew Robinson', 'username': 'chasinglogic', 'email': 'mathew.robinson@mongodb.com'}

Message: SERVER-40474 SERVER-25727 Only lint changed files
Branch: master
https://github.com/mongodb/mongo/commit/67db7ecdb3b64b452b03843ac384c3eae9185b5d

Comment by David Bradford (Inactive) [ 16/Sep/19 ]

I'm not sure lint-my or lint-patch are behaving as I would expect by default. When I try to run them, they are still analyzing everything in git.

As far as a target, I would love to see lint in a patch build processed in under 5 minutes on average (Right now it takes around 15 minutes).

Comment by Mathew Robinson (Inactive) [ 16/Sep/19 ]

david.bradford do you know what kind of speedup you're expecting? I did a few local tests on one of my working branches and I did not see noticeable a speed up between doing lint-all and lint-patch / format-all and format-my.

Comment by David Bradford (Inactive) [ 16/Sep/19 ]

I think it would be useful to only lint changed files in a patch build, then do a full lint on the mainline build. That way if anything managed to sneak in we will catch it.

Linting only changed files in patch builds would be a great improvement for the commit queue.

Comment by Mathew Robinson (Inactive) [ 12/Sep/19 ]

Would be a good time to also do SERVER-40474

Comment by Mathew Robinson (Inactive) [ 12/Sep/19 ]

Putting this into Triage again. david.bradford has asked that we re-prioritize this to reduce the commit queue times.

Generated at Thu Feb 08 04:10:01 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.