[SERVER-25894] _configsvrAddShard needs to be run with w:majority write concern Created: 31/Aug/16  Updated: 25/Jan/17  Resolved: 20/Sep/16

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 3.3.14

Type: Bug Priority: Major - P3
Reporter: Spencer Brody (Inactive) Assignee: Spencer Brody (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Related
related to SERVER-24738 Config servers incorrectly allow w:1 ... Closed
is related to SERVER-25915 Log when waiting for write concern Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Sharding 2016-09-19, Sharding 2016-10-10
Participants:
Linked BF Score: 0

 Comments   
Comment by Githook User [ 20/Sep/16 ]

Author:

{u'username': u'stbrody', u'name': u'Spencer T Brody', u'email': u'spencer@mongodb.com'}

Message: SERVER-25894 Run _configsvrAddShard with w:majority write concern
Branch: master
https://github.com/mongodb/mongo/commit/9045e1a530fc4558773b9cb3cf9da51e27526d5d

Comment by Spencer Brody (Inactive) [ 20/Sep/16 ]

Ah, but the code that automatically upconverts an unspecified write concern to a w:majority one on config server commands only runs if the command's 'supportsWriteConcern' virtual method returns true, which _configsvrAddShard's does not. So this is indeed a bug.

Comment by Spencer Brody (Inactive) [ 31/Aug/16 ]

Huh. Actually it looks like we automatically apply a w:majority write concern to all commands run against a config server that don't specify an explicit write concern. Not actually sure what's going on here then. I'm going to add some logging to when we wait for write concern to try to figure out what's going on here.

Comment by Spencer Brody (Inactive) [ 31/Aug/16 ]

If SERVER-24738 had been fixed we would have caught this much sooner.

Generated at Thu Feb 08 04:10:33 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.