[SERVER-25992] Remove Value(const char* value) constructor Created: 07/Sep/16  Updated: 05/Apr/17  Resolved: 16/Dec/16

Status: Closed
Project: Core Server
Component/s: Aggregation Framework
Affects Version/s: None
Fix Version/s: 3.5.2

Type: Task Priority: Major - P3
Reporter: Max Hirschhorn Assignee: Tess Avitabile (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-23356 ExpressionSubstrCPTest uses non-NUL t... Closed
is related to SERVER-25991 WithNullCharacter* test cases in Expr... Closed
Backwards Compatibility: Fully Compatible
Sprint: Query 2017-01-23
Participants:

 Description   

The convenience of the Value(const char* value) constructor doesn't seem to outweigh the potential risk (see SERVER-23356 and SERVER-25991) for erroneously attempting to construct a string literal with an embedded null byte.

The Value(StringData value) and user-defined literal constructor for StringData from SERVER-24651 seem sufficient for syntactic convenience.



 Comments   
Comment by Githook User [ 16/Dec/16 ]

Author:

{u'username': u'tessavitabile', u'name': u'Tess Avitabile', u'email': u'tess.avitabile@mongodb.com'}

Message: SERVER-25992 Remove Value(const char* value) constructor
Branch: master
https://github.com/mongodb/mongo/commit/d92892f7ad0a83252c788c08646d05ac46cfeabc

Generated at Thu Feb 08 04:10:50 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.