[SERVER-26309] Disable auto splitting in ShardingTest by default Created: 23/Sep/16 Updated: 19/Dec/17 Resolved: 29/Sep/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 3.2.11, 3.4.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Dianna Hohensee (Inactive) | Assignee: | Esha Maharishi (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | bkp, test-only | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||
| Backport Requested: |
v3.2
|
||||||||||||||||||||||||
| Sprint: | Sharding 2016-10-10 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Linked BF Score: | 0 | ||||||||||||||||||||||||
| Description |
|
Any test that does a moveChunk or split command is liable to run into issues because chunks are split unexpectedly. For example: We've seen ~5 BFs related to incorrect number of expected chunks, etc. |
| Comments |
| Comment by Githook User [ 04/Oct/16 ] |
|
Author: {u'name': u'Esha Maharishi', u'email': u'esha.maharishi@mongodb.com'}Message: |
| Comment by Githook User [ 30/Sep/16 ] |
|
Author: {u'name': u'Esha Maharishi', u'email': u'esha.maharishi@mongodb.com'}Message: |
| Comment by Githook User [ 29/Sep/16 ] |
|
Author: {u'username': u'monkey101', u'name': u'Dan Pasette', u'email': u'dan@mongodb.com'}Message: Revert " This reverts commit c47eb7408d712ac75c09b54079abfd0c28346a07. |
| Comment by Githook User [ 29/Sep/16 ] |
|
Author: {u'name': u'Esha Maharishi', u'email': u'esha.maharishi@mongodb.com'}Message: |
| Comment by Githook User [ 29/Sep/16 ] |
|
Author: {u'name': u'Esha Maharishi', u'email': u'esha.maharishi@mongodb.com'}Message: |
| Comment by Githook User [ 29/Sep/16 ] |
|
Author: {u'name': u'Esha Maharishi', u'email': u'esha.maharishi@mongodb.com'}Message: |
| Comment by Esha Maharishi (Inactive) [ 26/Sep/16 ] |
|
Oh, true, that's better than an sh.enableAutoSplit(). Good call. |
| Comment by Spencer Brody (Inactive) [ 26/Sep/16 ] |
|
If we make an enableAutosplit option to shardingTest (analogous to the existing enableBalancer option), then we won't need to blacklist tests that depend on autosplitting from the continuous stepdown suite. |
| Comment by Dianna Hohensee (Inactive) [ 26/Sep/16 ] |
|
Maybe we could have the stepdown suite's JS check for enabling auto split parameter, and avoid black listing those JS tests. It could do the write before starting stepdown, and the regular ShardingTest checks whether it's already set before trying a write? Might not be the cleanest idea. |
| Comment by Esha Maharishi (Inactive) [ 26/Sep/16 ] |
|
Tests that saw real errors that caused build failures:
The BF tickets for each of these failures are linked to this ticket. Test code changes required to disable autoSplit by default in master:
Test code changes required to disable autoSplit by default in 3.2:
To keep in mind:
|
| Comment by Daniel Pasette (Inactive) [ 23/Sep/16 ] |
|
Totally agree with disabling. Do we have any coverage of the autosplit code paths once disabled? How many sharding tests will enable it when this task is complete if any? |