[SERVER-26319] Deleting a test results in "ValueError: Unrecognized jstest" Created: 25/Sep/16 Updated: 29/Oct/18 Resolved: 25/Oct/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.5 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Waley Chen | Assignee: | Jonathan Abrahams |
| Resolution: | Done | Votes: | 0 |
| Labels: | tig-resmoke | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | DAG 2018-11-05 | ||||||||
| Participants: | |||||||||
| Story Points: | 1 | ||||||||
| Description |
|
When a file is included or excluded explicitly by name (i.e. not by glob pattern or tag), then an error is raised if the test isn't found. This is done to ensure that the blacklist for a suite is updated when a test is renamed or deleted. We should consider improving the "ValueError: Unrecognized jstest" error message to be clearer about potentially needing to update an entry in the blacklist. Original descriptionIn master, deleting the test loglong.js causes a failure: In this patch, I moved loglong.js to a new location and it causes the compile to fail: |
| Comments |
| Comment by Githook User [ 25/Oct/18 ] |
|
Author: {'name': 'Jonathan Abrahams', 'email': 'jonathan@mongodb.com', 'username': 'hptabster'}Message: |
| Comment by Jonathan Abrahams [ 24/Oct/18 ] |
|
We can either make this a warning message, or a fatal exception, Unrecognized test file: jstests/concurrency/fsm_workloads/findAndModify_update_grow1.js, should be removed from the exclude_files list.. |
| Comment by Max Hirschhorn [ 25/Oct/16 ] |
|
I'm turning this into an improvement request to make the "ValueError: Unrecognized jstest" error message more clear about potentially needing to update an entry in the blacklist. |
| Comment by Waley Chen [ 26/Sep/16 ] |
|
I see, thanks! Didn't know I had to update the blacklist. |
| Comment by Max Hirschhorn [ 26/Sep/16 ] |
|
waley.chen, resmoke.py errors if you reference a test in its suite configuration that doesn't exist. In this case, your commit removed the loglong.js test, but didn't update the blacklist in the sharded_collections_jscore_passthrough suite. |