[SERVER-26449] ExportedServerParameter with lambdas for get/set Created: 04/Oct/16 Updated: 06/Dec/17 Resolved: 28/Jun/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 3.5.10 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Mira Carey | Assignee: | Sara Golemon |
| Resolution: | Done | Votes: | 0 |
| Labels: | neweng, platforms-interns-2017 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Platforms 2017-07-10 | ||||||||
| Participants: | |||||||||
| Description |
|
ExportedServerParameter provides a valuable tool for reducing copy/paste code for general c++ variables, but is a little limited in scope. Providing a version which took lambdas for get and set would allow for substantially more coverage and further reduce the number of unique ServerParameter inheritors. |
| Comments |
| Comment by Sara Golemon [ 28/Jun/17 ] |
|
Changes implementation of ExportedServerParameter, but attempts to keep full BC with prior functionality. |
| Comment by Githook User [ 28/Jun/17 ] |
|
Author: {u'username': u'sgolemon', u'name': u'Sara Golemon', u'email': u'sara.golemon@mongodb.com'}Message: Implement BoundServerParameter class which accepts Moved ExportedServerParameter to be a child of BoundServerParameter. Implement LockedServerParameter class as child of |
| Comment by Andy Schwerin [ 04/Oct/16 ] |
|
Good idea. One challenge with ExportedServerParamter is that it provides pretty much no concurrency control. I think the model might be busted, because you hand a pointer to, say, a raw integer to ESP, and if it's runtime-settable, you don't specify how sets of the integer get synchronized. |