[SERVER-26457] Disallow maxTimeMS option to create command Created: 04/Oct/16  Updated: 06/Dec/22  Resolved: 05/Oct/16

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Tess Avitabile (Inactive) Assignee: Backlog - Query Team (Inactive)
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-26450 Whitelist maxTimeMS option to create ... Closed
Assigned Teams:
Query
Backwards Compatibility: Fully Compatible
Participants:

 Description   

The create command should not accept the maxTimeMS option, because we do not check for interrupt within its execution. However, create could not reject maxTimeMS in 3.4, because a 3.2 mongos attaches a maxTimeMS when creating the changelog and actionlog collections on the config servers. In 3.6, we should be able to disallow maxTimeMS for create.



 Comments   
Comment by Githook User [ 05/Oct/16 ]

Author:

{u'username': u'tessavitabile', u'name': u'Tess Avitabile', u'email': u'tess.avitabile@mongodb.com'}

Message: Remove TODO for SERVER-26457
Branch: master
https://github.com/mongodb/mongo/commit/d6884f02f84f3de70897ff0534921c91a036e05e

Comment by David Storch [ 05/Oct/16 ]

It's somewhat unfortunate that create in 3.2 and 3.4 must accept maxTimeMS, despite not actually enforcing the time limit. However, if we plan to make create interruptable in the future, then it does make sense to resolve this ticket as "Won't Fix". If we do so, then we should also remove the TODO comment in the code which references this ticket.

Comment by Andy Schwerin [ 04/Oct/16 ]

I disagree with cutting maxTimeMs from create. That command acquires locks, and in 3.6 I want to add interrupt support to lock acquisition.

Generated at Thu Feb 08 04:12:12 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.