[SERVER-26460] Add invariant to WiredTigerRecoveryUnit::_txnClose() Created: 04/Oct/16  Updated: 06/Dec/22  Resolved: 05/Oct/16

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: James Wahlin Assignee: Backlog - Storage Execution Team
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
Assigned Teams:
Storage Execution
Participants:
Linked BF Score: 0

 Description   

We should add the invariant shown below, on the line following https://github.com/mongodb/mongo/blob/master/src/mongo/db/storage/wiredtiger/wiredtiger_recovery_unit.cpp#L203

void WiredTigerRecoveryUnit::_txnClose(bool commit) {
    ...
    WT_SESSION* s = _session->getSession();
    invariant(s);
    ...
}



 Comments   
Comment by James Wahlin [ 05/Oct/16 ]

On further review, this invariant would not catch issues seen in the past. No need to add unless we see a real potential benefit.

Generated at Thu Feb 08 04:12:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.