[SERVER-26492] 2dsphere geoNear density estimator should stop once it exceeds $maxDistance Created: 05/Oct/16 Updated: 07/Dec/16 Resolved: 16/Nov/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Geo, Querying |
| Affects Version/s: | 3.0.12, 3.2.10 |
| Fix Version/s: | 3.2.12, 3.4.0-rc4 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | David Storch | Assignee: | David Storch |
| Resolution: | Done | Votes: | 3 |
| Labels: | code-only | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Backport Completed: | |||||||||
| Sprint: | Query 2016-11-21 | ||||||||
| Participants: | |||||||||
| Case: | (copied to CRM) | ||||||||
| Linked BF Score: | 0 | ||||||||
| Description |
| Comments |
| Comment by Githook User [ 22/Nov/16 ] |
|
Author: {u'username': u'dstorch', u'name': u'David Storch', u'email': u'david.storch@10gen.com'}Message: (cherry picked from commit c361d2b09242c150bd84576816d5337352fcbf55) |
| Comment by David Storch [ 16/Nov/16 ] |
|
This is now fixed for 3.4.0-rc4 in the master branch with the following commit. (It appears that our automated hook for posting commit comments failed due to transient problems with github availability.) https://github.com/mongodb/mongo/commit/c361d2b09242c150bd84576816d5337352fcbf55 We are currently in the process of releasing 3.2.11, which includes several important fixes, and cannot make further changes on the v3.2 branch. Therefore, this fix is now approved and targeted for 3.2.12. Approval for backport to the v3.0 branch is pending. |
| Comment by Githook User [ 15/Nov/16 ] |
|
Author: {u'username': u'dstorch', u'name': u'David Storch', u'email': u'david.storch@10gen.com'}Message: Revert " This reverts commit be3535a26e9c0d09ccf3ec5de0fd26ac48a3a6ff. |
| Comment by Githook User [ 15/Nov/16 ] |
|
Author: {u'username': u'dstorch', u'name': u'David Storch', u'email': u'david.storch@10gen.com'}Message: Revert " This reverts commit 1323228230603455daceafb0dc52f15be5363e99. |
| Comment by David Storch [ 15/Nov/16 ] |
|
I'm re-opening this ticket and reverting on both the master and 3.2 branches, since our continuous integration testing has discovered an issue with the patch. Work on a new patch is in progress. |
| Comment by Githook User [ 14/Nov/16 ] |
|
Author: {u'username': u'dstorch', u'name': u'David Storch', u'email': u'david.storch@10gen.com'}Message: (cherry picked from commit 1323228230603455daceafb0dc52f15be5363e99) |
| Comment by Githook User [ 11/Nov/16 ] |
|
Author: {u'username': u'dstorch', u'name': u'David Storch', u'email': u'david.storch@10gen.com'}Message: |
| Comment by Daniel Pasette (Inactive) [ 01/Nov/16 ] |
|
Hi girak, we understand the issue and are planning to work on this issue in the current sprint. Backports can only be made once we have a fix in place in master, but I've explicitly marked this issue as requested for backport. |
| Comment by Justin Leung [ 31/Oct/16 ] |
|
Hi @david.storch is there a reason why this critical bug fix is not being backported to both versions 3.0 and 3.2? |
| Comment by David Storch [ 19/Oct/16 ] |
|
Density estimation was added as a performance optimization during development for 3.0: see |