[SERVER-26946] Missed part of command response error in MigrationManager that should be checked with Shard::shouldErrorBePropagated() Created: 07/Nov/16 Updated: 19/Nov/16 Resolved: 10/Nov/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | 3.4.0-rc2 |
| Fix Version/s: | 3.4.0-rc4 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Esha Maharishi (Inactive) | Assignee: | Dianna Hohensee (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Sprint: | Sharding 2016-11-21 |
| Participants: |
| Description |
|
The MigrationManager uses Shard::shouldErrorBePropagated on remote moveChunk command responses to check for errors that should not propagated back to another server. While the existing code checks the command execution errors from RemoteCommandResponse.data, it does not check any errors in sending the command, which are in RemoteCommandResponse.status. This was an oversight. All errors resulting from the remote command should be checked, sending as well as execution, before propagation back to another server. Uncheck point: https://github.com/mongodb/mongo/commit/53efde3280dd6a880987150777f5a26143df59e1#diff-7ff1485b59b3f10b5aa430f42e785635R764 |
| Comments |
| Comment by Githook User [ 10/Nov/16 ] |
|
Author: {u'username': u'DiannaHohensee', u'name': u'Dianna Hohensee', u'email': u'dianna.hohensee@10gen.com'}Message: |