[SERVER-26955] ShardRemote _runCommand does not include the actual operation timeout as part of the command Created: 08/Nov/16 Updated: 05/Jun/17 Resolved: 11/Nov/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | 3.4.0-rc2 |
| Fix Version/s: | 3.4.0-rc4 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Kaloian Manassiev | Assignee: | Kaloian Manassiev |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Operating System: | ALL | ||||||||||||
| Sprint: | Sharding 2016-11-21 | ||||||||||||
| Participants: | |||||||||||||
| Linked BF Score: | 0 | ||||||||||||
| Description |
|
The ShardRemote::_runCommand call, which is used by all code paths which need to send a request to the config server or the shards does not include the remainder of the operation as part of the command. This means that for the cases where we do not override the maxTimeMS of a call it will end up using infinite maxTimeMS. |
| Comments |
| Comment by Kaloian Manassiev [ 03/Jun/17 ] |
|
Yes, this seems like the right thing to do. I have filed Thanks for bringing it up. |
| Comment by Tess Avitabile (Inactive) [ 02/Jun/17 ] |
|
kaloian.manassiev, now that last-stable=3.4, should max_time_ms_sharded_new_commands.js be combined with max_time_ms_sharded.js? |
| Comment by Githook User [ 11/Nov/16 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 11/Nov/16 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |