[SERVER-27008] Avoid unnecessary use of FieldPath inside ExpressionObject Created: 11/Nov/16 Updated: 19/Nov/16 Resolved: 14/Nov/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Aggregation Framework, Performance |
| Affects Version/s: | 3.4.0-rc3 |
| Fix Version/s: | 3.4.0-rc4 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Charlie Swanson | Assignee: | Charlie Swanson |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Sprint: | Query 2016-11-21 | ||||
| Participants: | |||||
| Description |
|
Inside ExpressionObject::evaluateInternal() we use MutableDocument::setNestedField() and a FieldPath, perhaps to handle dotted paths? But when parsing we assert the field names do not contain dots. We should use MutableDocument::addField() and stick with the string for both performance and clarity. |
| Comments |
| Comment by Githook User [ 16/Nov/16 ] |
|
Author: {u'username': u'cswanson310', u'name': u'Charlie Swanson', u'email': u'cswanson310@gmail.com'}Message: PERF-875 Add performance test for |
| Comment by Githook User [ 14/Nov/16 ] |
|
Author: {u'username': u'cswanson310', u'name': u'Charlie Swanson', u'email': u'charlie.swanson@mongodb.com'}Message: |
| Comment by Githook User [ 14/Nov/16 ] |
|
Author: {u'username': u'cswanson310', u'name': u'Charlie Swanson', u'email': u'cswanson310@gmail.com'}Message: PERF-875 Add performance test for |