[SERVER-27008] Avoid unnecessary use of FieldPath inside ExpressionObject Created: 11/Nov/16  Updated: 19/Nov/16  Resolved: 14/Nov/16

Status: Closed
Project: Core Server
Component/s: Aggregation Framework, Performance
Affects Version/s: 3.4.0-rc3
Fix Version/s: 3.4.0-rc4

Type: Improvement Priority: Major - P3
Reporter: Charlie Swanson Assignee: Charlie Swanson
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
Backwards Compatibility: Fully Compatible
Sprint: Query 2016-11-21
Participants:

 Description   

Inside ExpressionObject::evaluateInternal() we use MutableDocument::setNestedField() and a FieldPath, perhaps to handle dotted paths? But when parsing we assert the field names do not contain dots. We should use MutableDocument::addField() and stick with the string for both performance and clarity.



 Comments   
Comment by Githook User [ 16/Nov/16 ]

Author:

{u'username': u'cswanson310', u'name': u'Charlie Swanson', u'email': u'cswanson310@gmail.com'}

Message: PERF-875 Add performance test for SERVER-27008
Branch: master
https://github.com/mongodb/mongo-perf/commit/0225175efa85f157a18f5022b59676e62e1fb62b

Comment by Githook User [ 14/Nov/16 ]

Author:

{u'username': u'cswanson310', u'name': u'Charlie Swanson', u'email': u'charlie.swanson@mongodb.com'}

Message: SERVER-27008 Remove unnecessary use of FieldPath
Branch: master
https://github.com/mongodb/mongo/commit/1b1ac4cb6da9bc6f825bbc68861c6d93ddb01f9d

Comment by Githook User [ 14/Nov/16 ]

Author:

{u'username': u'cswanson310', u'name': u'Charlie Swanson', u'email': u'cswanson310@gmail.com'}

Message: PERF-875 Add performance test for SERVER-27008
Branch: develop
https://github.com/mongodb/mongo-perf/commit/0225175efa85f157a18f5022b59676e62e1fb62b

Generated at Thu Feb 08 04:13:54 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.