[SERVER-27193] Consider adding "small integer" optimizations to Stringbuilder Created: 28/Nov/16  Updated: 06/Dec/17  Resolved: 13/Jun/17

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 3.5.9

Type: Improvement Priority: Major - P3
Reporter: James Wahlin Assignee: Mathias Stearn
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-27175 Address slowness in Explain::getPlanS... Closed
Backwards Compatibility: Fully Compatible
Sprint: Repl 2017-03-06, Repl 2017-03-27, Repl 2017-04-17, Repl 2017-05-08, Repl 2017-05-29, Repl 2017-06-19
Participants:
Linked BF Score: 0

 Description   

We should optimize StringBuilder to handle writing small integers efficiently. See our itoa implementation for one approach. StringBuilder::operator<<(int) shows up as a CPU bottleneck when profiling our Query micro-benchmarks, mostly due to writing index specification to string.



 Comments   
Comment by Githook User [ 14/Jun/17 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-27193 Fix signed/unsigned mismatch compilation warnings on MSVC
Branch: master
https://github.com/mongodb/mongo/commit/a16bc9371921766d41e7a86c3ca10080c677ce6d

Comment by Githook User [ 13/Jun/17 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-27193 Use ItoA to handle integer cases in StringBuilder
Branch: master
https://github.com/mongodb/mongo/commit/c11900912d97df148a6970a3ec1e27d093923a0a

Generated at Thu Feb 08 04:14:25 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.