[SERVER-27211] de-duplicate multiply defined symbol `isMongos` Created: 29/Nov/16 Updated: 05/Apr/17 Resolved: 05/Dec/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 3.5.1 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Matt Cotter | Assignee: | ADAM Martin (Inactive) |
| Resolution: | Done | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Platforms 2017-01-23 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 0 | ||||||||
| Comments |
| Comment by Githook User [ 06/Dec/16 ] |
|
Author: {u'username': u'dgottlieb', u'name': u'Daniel Gottlieb', u'email': u'daniel.gottlieb@10gen.com'}Message: |
| Comment by Githook User [ 05/Dec/16 ] |
|
Author: {u'username': u'adamlsd', u'name': u'ADAM David Alan Martin', u'email': u'adam.martin@10gen.com'}Message: A hidden global variable representing the "is Mongos process" state |
| Comment by Matt Cotter [ 29/Nov/16 ] |
|
The views test crutch will go away. (or if there are other crutches that define more than just isMongos, they will be reduced) For a first stab, we planned to make it a global (which it sort of is already) because plumbing service contexts down to the unit tests where isMongos gets called would be a big diff. The goal of this effort is to remove multiply defined symbols and not necessarily to fix everything wrong with isMongos. We will definitely consider the possibility though. |
| Comment by Kyle Suarez [ 29/Nov/16 ] |
|
In addition, what does that mean for test crutches like this one? |
| Comment by Andy Schwerin [ 29/Nov/16 ] |
|
Is the plan to decorate the service context, or to cleverly eliminate it entirely? |