[SERVER-27217] Allow nopreallocj to be specified in YAML config file Created: 29/Nov/16  Updated: 05/Apr/17  Resolved: 05/Dec/16

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 3.2.12, 3.4.1, 3.5.1

Type: Task Priority: Major - P3
Reporter: Daniel Pasette (Inactive) Assignee: Eric Milkie
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Documented
is documented by SERVER-27138 Cannot run replSetStepDown for a 3.4 ... Closed
Related
Backwards Compatibility: Minor Change
Backport Completed:
Sprint: Storage 2016-12-12
Participants:
Linked BF Score: 0

 Description   

There is an inconsistency between what is allowed to be specified in the YAML config file, INI config file and cmd line parameters.



 Comments   
Comment by Githook User [ 05/Dec/16 ]

Author:

{u'username': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}

Message: SERVER-27217 check for new nopreallocj parameter full name when parsing options

(cherry picked from commit b21128fb4a78326bf4ad117d8bf97342cbd4f758)
Branch: v3.2
https://github.com/mongodb/mongo/commit/250021e2487e763aeb1eb7692a7b5942f65eb042

Comment by Githook User [ 05/Dec/16 ]

Author:

{u'username': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}

Message: SERVER-27217 check for new nopreallocj parameter full name when parsing options

(cherry picked from commit b21128fb4a78326bf4ad117d8bf97342cbd4f758)
Branch: v3.4
https://github.com/mongodb/mongo/commit/d9d8ac1e8ae85a07369274eaf12c0ce555e08b2e

Comment by Githook User [ 05/Dec/16 ]

Author:

{u'username': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}

Message: SERVER-27217 check for new nopreallocj parameter full name when parsing options
Branch: master
https://github.com/mongodb/mongo/commit/b21128fb4a78326bf4ad117d8bf97342cbd4f758

Comment by Max Hirschhorn [ 04/Dec/16 ]

The changes from d636714 introduced a bug where the --nopreallocj option now has no effect. This has caused various task failures in Evergreen when executing tests against the MMAPv1 storage engine, e.g. the mongod process takes too long to accept connections since it is busy allocating the journal file, or the extra space taken up by the journal files causes the machine to run out of disk space (SERVER-27267). The options parsing code is still using the short "nopreallocj" name for the option when attempting to check if it has been specified. However, the long "storage.mmapv1.journal.nopreallocj" name must be used instead because that's what is registered in the Environment.

if (params.count("nopreallocj")) {
	mmapv1GlobalOptions.preallocj = !params["nopreallocj"].as<bool>();
}


$ ./mongod --storageEngine=mmapv1 --nopreallocj
2016-12-04T18:31:14.026-0500 I CONTROL  [main] params.count("nopreallocj"): 0
2016-12-04T18:31:14.026-0500 I CONTROL  [main] params.count("storage.mmapv1.journal.nopreallocj"): 1

diff --git a/src/mongo/db/mongod_options.cpp b/src/mongo/db/mongod_options.cpp
index 10e89df..985ce46 100644
--- a/src/mongo/db/mongod_options.cpp
+++ b/src/mongo/db/mongod_options.cpp
@@ -1100,6 +1100,11 @@ Status storeMongodOptions(const moe::Environment& params) {
     if (params.count("storage.mmapv1.journal.debugFlags")) {
         mmapv1GlobalOptions.journalOptions = params["storage.mmapv1.journal.debugFlags"].as<int>();
     }
+
+    log() << "params.count(\"nopreallocj\"): " << params.count("nopreallocj");
+    log() << "params.count(\"storage.mmapv1.journal.nopreallocj\"): "
+          << params.count("storage.mmapv1.journal.nopreallocj");
+
     if (params.count("nopreallocj")) {
         mmapv1GlobalOptions.preallocj = !params["nopreallocj"].as<bool>();
     }

Comment by Githook User [ 01/Dec/16 ]

Author:

{u'username': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}

Message: SERVER-27217 fix lint
Branch: v3.2
https://github.com/mongodb/mongo/commit/33de179d5337c1169e6d50f81989a2d6cc893fd8

Comment by Githook User [ 01/Dec/16 ]

Author:

{u'username': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}

Message: SERVER-27217 fix command_line_parsing.js

(cherry picked from commit b88aa488a196fff387d443fc2e8c08f3bb6fed2d)
Branch: v3.2
https://github.com/mongodb/mongo/commit/b1f28cc9ab6858327a1e6e44edec4cd74e12ac14

Comment by Githook User [ 01/Dec/16 ]

Author:

{u'username': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}

Message: SERVER-27217 Allow nopreallocj to be specified in a YAML config file

(cherry picked from commit d6367145b2844b289b87c9b235e453e0f80c5f42)
Branch: v3.2
https://github.com/mongodb/mongo/commit/6f904c0c49a3a86559b96f99365a36cf942e5779

Comment by Githook User [ 01/Dec/16 ]

Author:

{u'username': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}

Message: SERVER-27217 fix command_line_parsing.js

(cherry picked from commit b88aa488a196fff387d443fc2e8c08f3bb6fed2d)
Branch: v3.4
https://github.com/mongodb/mongo/commit/9c07ee6949f0cb5322e46384c26338f98c2b17e3

Comment by Githook User [ 01/Dec/16 ]

Author:

{u'username': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}

Message: SERVER-27217 Allow nopreallocj to be specified in a YAML config file

(cherry picked from commit d6367145b2844b289b87c9b235e453e0f80c5f42)
Branch: v3.4
https://github.com/mongodb/mongo/commit/00f3ffbc3e280940b81ba1bfeaf2c62537a05984

Comment by Githook User [ 01/Dec/16 ]

Author:

{u'username': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}

Message: SERVER-27217 fix command_line_parsing.js
Branch: master
https://github.com/mongodb/mongo/commit/b88aa488a196fff387d443fc2e8c08f3bb6fed2d

Comment by Githook User [ 30/Nov/16 ]

Author:

{u'username': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}

Message: SERVER-27217 Allow nopreallocj to be specified in a YAML config file
Branch: master
https://github.com/mongodb/mongo/commit/d6367145b2844b289b87c9b235e453e0f80c5f42

Generated at Thu Feb 08 04:14:30 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.