[SERVER-27328] Check the returned OpTime by multiApply() in 3.2 initial sync Created: 07/Dec/16  Updated: 06/Dec/22  Resolved: 20/Jan/17

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: 3.2.0
Fix Version/s: None

Type: Bug Priority: Minor - P4
Reporter: Siyuan Zhou Assignee: Backlog - Replication Team
Resolution: Won't Fix Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Assigned Teams:
Replication
Operating System: ALL
Participants:
Linked BF Score: 0

 Description   

multiApply() may return null optime during shutdown after SERVER-21868. Null optime will hit an invariant in setMyLastAppliedOpTime(). We should check optime before setting my last applied optime.



 Comments   
Comment by Siyuan Zhou [ 08/Dec/16 ]

The code has been changed dramatically by redbeard0531 in commit 34c6c69 and 15c1925. It seems the issue has been fixed by joining the writes in multiApply(), so multiApply doesn't return an error anymore. The linked build failure happened in March anyway.

Changing this to a lower priority and waiting for Mathias's confirm.

Comment by Judah Schvimer [ 08/Dec/16 ]

initial_sync.cpp is only used in the old initial sync. SyncTail::multiApply, is also used in steady state replication I think.

Comment by Siyuan Zhou [ 07/Dec/16 ]

judah.schvimer, this only happens in old initial sync right?

Generated at Thu Feb 08 04:14:51 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.