[SERVER-27329] Move BackgroundSync::_rollback into rs_rollback.cpp and unit test it Created: 08/Dec/16 Updated: 31/May/17 Resolved: 09/Mar/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 3.4.4, 3.5.5 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Spencer Brody (Inactive) | Assignee: | Benety Goh |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Backport Completed: | |||||
| Sprint: | Repl 2017-03-27 | ||||
| Participants: | |||||
| Description |
|
BackgroundSync::_rollback doesn't depend on any member state of BackgroundSync. We should move it into rs_rollback.cpp with the rest of the rollback code and add unit tests for its behavior. |
| Comments |
| Comment by Githook User [ 31/Mar/17 ] |
|
Author: {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}Message: added test case for failing to transition to ROLLBACK (cherry picked from commit 73d3473fb11ff4fbdb404d0c6c409a309ccd7646) |
| Comment by Githook User [ 31/Mar/17 ] |
|
Author: {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}Message: Added optional override for sleepsecs to rollback() for testing. (cherry picked from commit d44517bc2cfefbc3c1a68626d511f0e2ade559f6) |
| Comment by Githook User [ 31/Mar/17 ] |
|
Author: {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}Message: Moved dependencies on concrete classes and StorageInterace::get() out of _rollback() This commit also removes the dependency on StorageInterface::get() from syncRollback(). (cherry picked from commit 6d40cc3281fcd71d59db3c29c7a0b21ba0eecdc6) |
| Comment by Githook User [ 31/Mar/17 ] |
|
Author: {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}Message: (cherry picked from commit 5471f25a04f8f2617a8737617856e3659f33bca9) |
| Comment by Githook User [ 09/Mar/17 ] |
|
Author: {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}Message: added test case for failing to transition to ROLLBACK |
| Comment by Githook User [ 08/Mar/17 ] |
|
Author: {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}Message: Added optional override for sleepsecs to rollback() for testing. |
| Comment by Githook User [ 08/Mar/17 ] |
|
Author: {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}Message: Moved dependencies on concrete classes and StorageInterace::get() out of _rollback() This commit also removes the dependency on StorageInterface::get() from syncRollback(). |
| Comment by Githook User [ 08/Mar/17 ] |
|
Author: {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}Message: |