[SERVER-27339] ReplSetTest shouldn't inspect TestData directly Created: 08/Dec/16  Updated: 05/Apr/17  Resolved: 17/Dec/16

Status: Closed
Project: Core Server
Component/s: Replication, Testing Infrastructure
Affects Version/s: None
Fix Version/s: 3.4.2, 3.5.2

Type: Bug Priority: Major - P3
Reporter: Judah Schvimer Assignee: Kaloian Manassiev
Resolution: Done Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Duplicate
is duplicated by SERVER-27445 ReplSetTest throws 'TypeError: TestDa... Closed
Related
related to SERVER-27117 set writeConcernMajorityJournalDefaul... Closed
related to SERVER-26747 replSetStepDown should wait for last ... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v3.4, v3.2
Participants:

 Description   

ReplSetTest uses the TestData object provided by resmoke to determine if journaling is on and if the storage engine requires persistence. If a ReplSetTest is started by mongo --nodb, there is no TestData object. This is a problem in the following two places:

https://github.com/mongodb/mongo/blob/d55eb9d186f3039695a4d710116e79ad04536409/src/mongo/shell/replsettest.js#L623-L624
https://github.com/mongodb/mongo/blob/d55eb9d186f3039695a4d710116e79ad04536409/src/mongo/shell/replsettest.js#L295-L296



 Comments   
Comment by Githook User [ 28/Dec/16 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-27339 Use jsTestOptions() in ReplSetTest instead of TestData

(cherry picked from commit e41c763fb9f750fc3ecf22cf284c79361d345762)
Branch: v3.4
https://github.com/mongodb/mongo/commit/1b90122cd2f402a476c90ee845f79f4343edd0ef

Comment by Githook User [ 17/Dec/16 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-27339 Use jsTestOptions() in ReplSetTest instead of TestData
Branch: master
https://github.com/mongodb/mongo/commit/e41c763fb9f750fc3ecf22cf284c79361d345762

Comment by Spencer Brody (Inactive) [ 08/Dec/16 ]

I don't feel like it's a problem for ReplSetTest to look at the test configuration, so long as it doesn't cause any errors when TestData isn't present. I think if we switched every place we checked TestData directly we instead called jsTestOptions(), then this would just work.

Generated at Thu Feb 08 04:14:53 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.