[SERVER-27367] Deduplicate multiply defined member functions of the mongo::Command class Created: 10/Dec/16 Updated: 12/Dec/16 Resolved: 12/Dec/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | DO NOT USE - Backlog - Platform Team |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Participants: | |||||||||
| Description |
|
The Command class methods Command::registerError, Command::findCommand, and Command::execCommand are currently implemented differently in mongod and mongos. This means that any library that depends on the Command class cannot fully express its dependencies, since it cannot know whether it is ultimately to be linked into mongod or mongos. We should either find a way to unify the implementations, or find a way to dependency inject different helper implementations. |
| Comments |
| Comment by Andrew Morrow (Inactive) [ 12/Dec/16 ] |
|
We will track this instead on a per-method basis for mongo::Command. |