[SERVER-27410] Make the lint task required by compile on Enterprise RHEL 6.2 Created: 13/Dec/16  Updated: 31/May/18  Resolved: 03/Jan/17

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 3.4.16, 3.5.2

Type: Improvement Priority: Major - P3
Reporter: Jonathan Abrahams Assignee: Jonathan Abrahams
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v3.4
Sprint: TIG 2017-01-02
Participants:

 Description   

This will ensure that the lint task is always scheduled, regardless of what the user selects when configuring a patch build on the Enterprise RHEL 6.2 host.



 Comments   
Comment by Githook User [ 31/May/18 ]

Author:

{'username': 'elouie99', 'name': 'Eddie Louie', 'email': 'eddie.louie@mongodb.com'}

Message: SERVER-27410 Make the lint task required by compile on Enterprise RHEL 6.2

(cherry picked from commit 10836c80d24114ce67518b1a6b283c9407c4bfea)
Branch: v3.4
https://github.com/mongodb/mongo/commit/c049f3a80385c54e22100846fff616fa3b76b03c

Comment by Githook User [ 03/Jan/17 ]

Author:

{u'username': u'elouie99', u'name': u'Eddie Louie', u'email': u'eddie.louie@mongodb.com'}

Message: SERVER-27410 Make the lint task required by compile on Enterprise RHEL 6.2
Branch: master
https://github.com/mongodb/mongo/commit/10836c80d24114ce67518b1a6b283c9407c4bfea

Comment by Max Hirschhorn [ 13/Dec/16 ]

Won't this slow things down by 8-10 minutes? Is this desirable?

I don't see why it would. The "compile" task doesn't depends_on the "lint" task and the "lint" task doesn't depends_on the "compile" task, so they should still be able to run on separate machines in parallel (if that's what the Evergreen scheduler decides to do). The notion of requires in Evergreen project configuration doesn't enforce an ordering for how tasks run as far as I could tell.

The thing it would do is ensure that developers who don't click the "all" checkbox for their patch builds don't inadvertently not run the "lint" task.

Comment by Ramon Fernandez Marina [ 13/Dec/16 ]

Won't this slow things down by 8-10 minutes? Is this desirable?

Comment by Jonathan Abrahams [ 13/Dec/16 ]

Compile task will require lint task to run, after it completes, not the other way around.

Comment by Kyle Suarez [ 13/Dec/16 ]

Will this not schedule a compile if you fail lint?

Generated at Thu Feb 08 04:15:06 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.