[SERVER-27412] Rollback exceptions should have better error messages Created: 13/Dec/16  Updated: 06/Dec/17  Resolved: 12/Jun/17

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 3.5.9

Type: Improvement Priority: Major - P3
Reporter: Judah Schvimer Assignee: Allison Chang
Resolution: Done Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
Backwards Compatibility: Fully Compatible
Sprint: Repl 2017-06-19
Participants:
Linked BF Score: 0

 Description   

Rollback throws RSFatalExceptions that have the default message "replica set fatal exception". In rollback, we throw multiple of these without changing the default which makes debugging more confusing. Almost every time we log an error message and then throw an empty exception. We should include the logged error message in the exception.



 Comments   
Comment by Allison Chang [ 13/Jun/17 ]

https://evergreen.mongodb.com/version/593f04b02fbabe5f9c00282d

Comment by Githook User [ 13/Jun/17 ]

Author:

{u'username': u'archang68', u'name': u'Allison Chang', u'email': u'allison.chang@10gen.com'}

Message: SERVER-27412: Updates the error messages for RSFatalExceptions in rs_rollback to be more descriptive
Branch: master
https://github.com/mongodb/mongo/commit/bce4f6142f139ccff91e32ce445086b1c646d9cf

Comment by Githook User [ 12/Jun/17 ]

Author:

{u'username': u'nathan-myers-mongo', u'name': u'Nathan Myers', u'email': u'nathan.myers@10gen.com'}

Message: Revert "SERVER-27412: Updates the error messages for RSFatalExceptions in rs_rollback to be more descriptive"

This reverts commit 7aecd4552f0e913e4e4a169c366b7d450e32e05b.
Branch: master
https://github.com/mongodb/mongo/commit/0e4f02db8931419e8c648852daedcb02e97291b8

Comment by Githook User [ 12/Jun/17 ]

Author:

{u'username': u'archang68', u'name': u'Allison Chang', u'email': u'allison.chang@10gen.com'}

Message: SERVER-27412: Updates the error messages for RSFatalExceptions in rs_rollback to be more descriptive
Branch: master
https://github.com/mongodb/mongo/commit/7aecd4552f0e913e4e4a169c366b7d450e32e05b

Generated at Thu Feb 08 04:15:06 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.