[SERVER-27556] Cleanup sharding request processing code Created: 30/Dec/16  Updated: 05/Apr/17  Resolved: 07/Jan/17

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: 3.5.1
Fix Version/s: 3.4.2, 3.5.2

Type: Improvement Priority: Major - P3
Reporter: Kaloian Manassiev Assignee: Kaloian Manassiev
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v3.4
Sprint: Sharding 2017-01-02
Participants:

 Description   

Cleanup unnecessary or unused code from src/mongo/s/commands/request.h/.cpp to make the request code path more understandable.



 Comments   
Comment by Githook User [ 12/Jan/17 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-27556 Cleanup sharding request processing code

(cherry picked from commit 77b263defe4ce37eb31fa5f7dda52018b148d63a)
(cherry picked from commit 5fd8887479dabbcb23a4084286ef2f0d5cc267c4)
(cherry picked from commit 6dd2c8edd95ad1e3afc8473e8d5e5885572c9477)
(cherry picked from commit 3f51a51845e2c8c5b748905b7f8f472cb379f6e8)
Branch: v3.4
https://github.com/mongodb/mongo/commit/66735ea4c098f1e8c2947ed8c833a91afc71f0d0

Comment by Githook User [ 11/Jan/17 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-27556/SERVER-27608 Fix a Coverity unchecked return value warning
Branch: master
https://github.com/mongodb/mongo/commit/3f51a51845e2c8c5b748905b7f8f472cb379f6e8

Comment by Githook User [ 07/Jan/17 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-27556 Remove usages of Request in strategy.h/.cpp

Removes it from Strategy::queryOp/getMore, Strategy::killCursors,
Strategy::writeOp and Strategy::clientCommandOp.
Branch: master
https://github.com/mongodb/mongo/commit/6dd2c8edd95ad1e3afc8473e8d5e5885572c9477

Comment by Githook User [ 03/Jan/17 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-27556 Remove Request::session and usages of cc() in request processing
Branch: master
https://github.com/mongodb/mongo/commit/5fd8887479dabbcb23a4084286ef2f0d5cc267c4

Comment by Githook User [ 03/Jan/17 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-27556 Cleanup sharding request processing code

No functional changes, just going in the direction of removing
request.h/.cpp.
Branch: master
https://github.com/mongodb/mongo/commit/77b263defe4ce37eb31fa5f7dda52018b148d63a

Generated at Thu Feb 08 04:15:30 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.