[SERVER-27577] thin_archive.py tool should not apply to the Library builder Created: 04/Jan/17  Updated: 05/Apr/17  Resolved: 07/Jan/17

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 3.5.2

Type: Bug Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Andrew Morrow (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v3.4
Sprint: Platforms 2017-01-23
Participants:

 Description   

In our environment, the Library builder may be bound to either the StaticLibrary or the SharedLibrary builder. The thin_archive.py SCons Tool unconditionally updates the signature for both the Library and StaticLibrary builders, which is a mistake when the Library builder is actually the SharedLibrary builder, not an alias for the StaticLibrary builder (as is the SCons default).



 Comments   
Comment by Githook User [ 07/Jan/17 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-27577 Only apply thin_archive handling to StaticLibrary

By default on SCons, the Library and StaticLibrary builders are
the same object, so adding the target_factory to StaticLibrary is
sufficient. If they aren't the same, then even more important
to only modify SaticLibrary, since Library may have been re-purposed
to mean something else. In our case it does mean something different
when using --link-model=dynamic, so this oversight inadvertently changed
the signature calculations for dynamic libaries.

Also includes a drive-by fix to add LoadableModule to the builders
affected by the abilink.py tool, since a LoadableModule is also
a shared library on the platforms where abidw is in play.
Branch: master
https://github.com/mongodb/mongo/commit/ef364240d7d48a8a352afb91df5cddbd34394021

Generated at Thu Feb 08 04:15:34 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.