[SERVER-27770] Remove resmoke.py's includeWithAllTags and excludeWithAllTags arguments Created: 20/Jan/17  Updated: 06/Dec/17  Resolved: 27/Mar/17

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: 3.5.1
Fix Version/s: 3.5.6

Type: Improvement Priority: Major - P3
Reporter: Robert Guo (Inactive) Assignee: Eddie Louie
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: TIG 2017-04-17
Participants:

 Description   

SERVER-27408 introduced a way for resmoke to accept multiple copies of tag-related arguments. This allowed resmoke arguments for a variant, task, and suite to be concatenated easily.

As part of the change, each tag-related argument is only allowed decrease the number of tests run. (E.g setting includeWithAnyTag will not override a previous excludeWithAnyTag; it will only filter whatever tests remain after the excludeWithAnyTag filter has run.) This is to ensure resmoke's arguments are impervious to ordering, which is the expected behavior of command line arguments.

A side effect of the strict filtering requirement is that --excludeWithAllTags=t1 --excludeWithAllTag=t2 can not mean the same thing as --excludeWithAllTags=t1,t2, since the latter has a narrower exclusion scope, even though it is what users would expect.

Currently, resmoke implements the incorrect behavior, so that it is at least consistent with users' expectations. Implementing the correct behavior requires quite a bit of work and will be confusing to users.

Given that no one is using excludeWithAllTags and includeWithAllTags at the moment, the quickest fix is to remove support for the includeWithAllTags and excludeWithAllTags command line arguments and include_with_all_tags and exclude_with_all_tags YAML options in the suite definition.



 Comments   
Comment by Githook User [ 27/Mar/17 ]

Author:

{u'username': u'elouie99', u'name': u'Eddie Louie', u'email': u'eddie.louie@mongodb.com'}

Message: SERVER-27770 Remove other references to EXCLUDE_WITH_ALL_TAGS and
INCLUDE_WITH_ALL_TAGS
Branch: master
https://github.com/mongodb/mongo/commit/422a7e6dddf42d09b7b9037f67d0da16de7c5968

Comment by Githook User [ 27/Mar/17 ]

Author:

{u'username': u'elouie99', u'name': u'Eddie Louie', u'email': u'eddie.louie@mongodb.com'}

Message: SERVER-27770 Remove resmoke.py's includeWithAllTags and excludeWithAllTags options
Branch: master
https://github.com/mongodb/mongo/commit/5e47fab7c971014ae7ce401e94d35dc761fea8c2

Generated at Thu Feb 08 04:16:11 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.