[SERVER-27773] Add operationTime to command response Created: 20/Jan/17 Updated: 24/Aug/17 Resolved: 28/Feb/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 3.5.4 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Misha Tyulenev | Assignee: | Misha Tyulenev |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Sharding 2017-03-06 | ||||||||
| Participants: | |||||||||
| Description |
|
The goal is to put the "operationTime" filed in the command response. Therefore it will be
The method should return just a clusterTime known to the node, the actual implementation will be done in 1. add to commands.[h cpp]
2. add to dbcommands.[h cpp]
3. The appendOperationTime should be called in the Command::run() with the inPlaceReplyBob as an argument. 4. Add unit tests |
| Comments |
| Comment by Ramon Fernandez Marina [ 24/Aug/17 ] |
|
|
| Comment by Randolph Tan [ 21/Feb/17 ] |
|
misha I was initially confused because I interprted the api in the decription as "every command will need it's own implementation of appendOperationTime" and it looks like that's not the case. I just wanted to say that we already have get last client opTime and it looks like that's what you are going to use. |
| Comment by Misha Tyulenev [ 19/Feb/17 ] |
|
renctan the appendOpTimeMetadata modifies the replMetadata. The design spec (page9) requests to add it to the Here is the recap: the operationTime value will be used in the follow up read request arguments In the follow up txn I plan to use the same repl::ReplClientInfo::forClient(txn->getClient()).getLastOp(); value as used in the appendOpTimeMetadata - but this will be discussed separately. |
| Comment by Misha Tyulenev [ 17/Feb/17 ] |
|
milkie, renctan , can you please review this change when its implemented? Are you agree with the approach detailed in the ticket description? |