[SERVER-27783] Remove unnecessary lock in SyncSourceFeedback Created: 23/Jan/17 Updated: 05/Apr/17 Resolved: 23/Jan/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 3.2.12, 3.4.3, 3.5.2 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Judah Schvimer | Assignee: | Judah Schvimer |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Backport Requested: |
v3.4, v3.2
|
||||||||||||
| Sprint: | Repl 2017-01-23, Repl 2017-02-13 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
We currently take a lock to get the ReplicationCoordinator and then prepare a ReplSetUpdatePosition command. None of these things need a lock and it appears to mostly be a vestige of old code that needed it. This will also help the backport of the LastVote work to 3.2. |
| Comments |
| Comment by Githook User [ 06/Feb/17 ] |
|
Author: {u'username': u'judahschvimer', u'name': u'Judah Schvimer', u'email': u'judah@mongodb.com'}Message: (cherry picked from commit 52f8f4d7639219f12bf696f0538bc13af04a3708) |
| Comment by Githook User [ 24/Jan/17 ] |
|
Author: {u'username': u'judahschvimer', u'name': u'Judah Schvimer', u'email': u'judah@mongodb.com'}Message: |
| Comment by Benety Goh [ 23/Jan/17 ] |
|
This lock became unnecessary when we removed the _handshakeNeeded field in |
| Comment by Githook User [ 23/Jan/17 ] |
|
Author: {u'username': u'judahschvimer', u'name': u'Judah Schvimer', u'email': u'judah@mongodb.com'}Message: |