[SERVER-27783] Remove unnecessary lock in SyncSourceFeedback Created: 23/Jan/17  Updated: 05/Apr/17  Resolved: 23/Jan/17

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 3.2.12, 3.4.3, 3.5.2

Type: Improvement Priority: Major - P3
Reporter: Judah Schvimer Assignee: Judah Schvimer
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
is related to SERVER-15698 Remove support for RIDs in slave trac... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v3.4, v3.2
Sprint: Repl 2017-01-23, Repl 2017-02-13
Participants:

 Description   

We currently take a lock to get the ReplicationCoordinator and then prepare a ReplSetUpdatePosition command. None of these things need a lock and it appears to mostly be a vestige of old code that needed it. This will also help the backport of the LastVote work to 3.2.



 Comments   
Comment by Githook User [ 06/Feb/17 ]

Author:

{u'username': u'judahschvimer', u'name': u'Judah Schvimer', u'email': u'judah@mongodb.com'}

Message: SERVER-27783 Removed unnecessary lock in SyncSourceFeedback

(cherry picked from commit 52f8f4d7639219f12bf696f0538bc13af04a3708)
Branch: v3.4
https://github.com/mongodb/mongo/commit/26cf18218abab11ab09be79cbfafc0f9882de8af

Comment by Githook User [ 24/Jan/17 ]

Author:

{u'username': u'judahschvimer', u'name': u'Judah Schvimer', u'email': u'judah@mongodb.com'}

Message: SERVER-27783 removed SyncSourceFeedback lock around preparing ReplSetUpdatePosition commands
Branch: v3.2
https://github.com/mongodb/mongo/commit/a89275be8ed3401c3f00357b90720fcee94e3f79

Comment by Benety Goh [ 23/Jan/17 ]

This lock became unnecessary when we removed the _handshakeNeeded field in SERVER-15698:

https://github.com/mongodb/mongo/commit/7ed5259ea72ad18e6b56450d7e23a269191b424a#diff-35adcec92a9510aef189e95a6ccd74d8L206

Comment by Githook User [ 23/Jan/17 ]

Author:

{u'username': u'judahschvimer', u'name': u'Judah Schvimer', u'email': u'judah@mongodb.com'}

Message: SERVER-27783 Removed unnecessary lock in SyncSourceFeedback
Branch: master
https://github.com/mongodb/mongo/commit/52f8f4d7639219f12bf696f0538bc13af04a3708

Generated at Thu Feb 08 04:16:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.